Fix crash bug in save card bubble on Mac.

Fix crash bug in save card bubble on Mac.

BUG=633254
Committed: https://crrev.com/627ae2df06b9e080a0b34d16a54a0d4d7cab57da
Cr-Commit-Position: refs/heads/master@{#411409}

[Justin Donnelly, 2016-08-08 22:05:37]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:09:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Justin Donnelly, 2016-08-08 22:09:47]

Patchset #1 (id:1) has been deleted

[Justin Donnelly, 2016-08-08 22:10:10]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:10:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:53:03]

Dry run: This issue passed the CQ dry run.

[Justin Donnelly, 2016-08-08 22:55:30]

jdonnelly@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2016-08-10 19:49:35]

https://codereview.chromium.org/2227743003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm (right):

https://codereview.chromium.org/2227743003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm:101: void
SaveCardBubbleViewBridge::Hide() {
That means Hide() can be called several times? How does that happen, and could
that be an issue on Views as well?

[Justin Donnelly, 2016-08-11 15:41:15]

https://codereview.chromium.org/2227743003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm (right):

https://codereview.chromium.org/2227743003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm:101: void
SaveCardBubbleViewBridge::Hide() {
On 2016/08/10 19:49:35, groby wrote:
> That means Hide() can be called several times? How does that happen, and could
> that be an issue on Views as well?

Well, to be honest, I can't say that I 100% understand what's going on with this
crash. That said, Hide is called from several locations here and in the
controller. They're designed to result in only one invocation but the sequence
of events is complicated. My hypothesis is that the controller is being deleted
concurrently with a navigation. Both of these call Hide.

As for Views, it has a different lifecycle. But it has similar defensive checks
on controller_:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/autofill/save_ca...

[groby-ooo-7-16, 2016-08-11 17:53:34]

LGTM

(Grumbly so. I hate it when we have bugs where we patch the symptom instead of
the root cause, but I still prefer not crashing)

[Justin Donnelly, 2016-08-11 18:13:27]

On 2016/08/11 17:53:34, groby wrote:
> LGTM

Thanks.
 
> (Grumbly so. I hate it when we have bugs where we patch the symptom instead of
> the root cause, but I still prefer not crashing)

I do not disagree.

[Justin Donnelly, 2016-08-11 18:15:49]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:16:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:52:29]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-11 19:54:20]

Description was changed from

==========
Fix crash bug in save card bubble on Mac.

BUG=633254
==========

to

==========
Fix crash bug in save card bubble on Mac.

BUG=633254

Committed: https://crrev.com/627ae2df06b9e080a0b34d16a54a0d4d7cab57da
Cr-Commit-Position: refs/heads/master@{#411409}
==========

[commit-bot: I haz the power, 2016-08-11 19:54:21]

Patchset 1 (id:??) landed as
https://crrev.com/627ae2df06b9e080a0b34d16a54a0d4d7cab57da
Cr-Commit-Position: refs/heads/master@{#411409}