Issue 2227733003: Don't compare the hash in AstRawStringCompare since it's guaranteed by the HashMap implementation

Issue 2227733003: Don't compare the hash in AstRawStringCompare since it's guaranteed by the HashMap implementation (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 4 months ago

Reviewers:
marja

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Don't compare the hash in AstRawStringCompare since it's guaranteed by the HashMap implementation BUG= Committed: https://crrev.com/7e065bad8c693a61d1c6cc5b1fabe23c807591db Cr-Commit-Position: refs/heads/master@{#38527}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ast/ast-value-factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

marja

lgtm I tried to remember what was behind this, but couldn't.

4 years, 4 months ago (2016-08-10 08:22:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227733003/1

4 years, 4 months ago (2016-08-10 09:22:00 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-10 09:43:59 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7e065bad8c693a61d1c6cc5b1fabe23c807591db
Cr-Commit-Position: refs/heads/master@{#38527}