Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issue 2227723003: Fix mistake in FastNewFunctionContextStub (Closed)

Created:
4 years, 4 months ago by klaasb
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix mistake in FastNewFunctionContextStub We assumed we could use a do..while, but the requested amount of slots could've been 0 and we already started at MIN_CONTEXT_SLOTS. In that case the loop should've been skipped. Committed: https://crrev.com/ab674bab6d9e598d4b6c6add5094cb33c36d5647 Cr-Commit-Position: refs/heads/master@{#38499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/code-stubs.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
klaasb
Fix for a wrong assumption in the original CL.
4 years, 4 months ago (2016-08-09 14:55:32 UTC) #2
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-09 14:59:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227723003/1
4 years, 4 months ago (2016-08-09 15:00:48 UTC) #7
rmcilroy
lgtm
4 years, 4 months ago (2016-08-09 15:05:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 15:20:58 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:21:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab674bab6d9e598d4b6c6add5094cb33c36d5647
Cr-Commit-Position: refs/heads/master@{#38499}

Powered by Google App Engine
This is Rietveld 408576698