Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: android_webview/browser/in_process_view_renderer.cc

Issue 22277004: Add gfx::SurfaceFactoryWebview (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: InProcessContext takes attrib struct Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/in_process_view_renderer.cc
diff --git a/android_webview/browser/in_process_view_renderer.cc b/android_webview/browser/in_process_view_renderer.cc
index a714956e08064795b9da15890fab5f8cddc411f6..3223597a422bb5b73b04d2c6006b61b2156f9cdd 100644
--- a/android_webview/browser/in_process_view_renderer.cc
+++ b/android_webview/browser/in_process_view_renderer.cc
@@ -6,6 +6,7 @@
#include <android/bitmap.h>
+#include "android_webview/browser/aw_gl_surface.h"
#include "android_webview/browser/scoped_app_gl_state_restore.h"
#include "android_webview/common/aw_switches.h"
#include "android_webview/public/browser/draw_gl.h"
@@ -289,6 +290,16 @@ bool InProcessViewRenderer::OnDraw(jobject java_canvas,
return result;
}
+bool InProcessViewRenderer::InitializeHwDraw() {
+ TRACE_EVENT0("android_webview", "InitializeHwDraw");
+ DCHECK(!gl_surface_);
+ gl_surface_ = new AwGLSurface;
+ hardware_failed_ = !compositor_->InitializeHwDraw(gl_surface_);
+ hardware_initialized_ = true;
+
+ return !hardware_failed_;
+}
+
void InProcessViewRenderer::DrawGL(AwDrawGLInfo* draw_info) {
TRACE_EVENT0("android_webview", "InProcessViewRenderer::DrawGL");
DCHECK(visible_);
@@ -309,12 +320,9 @@ void InProcessViewRenderer::DrawGL(AwDrawGLInfo* draw_info) {
ScopedAllowGL allow_gl;
if (attached_to_window_ && compositor_ && !hardware_initialized_) {
- TRACE_EVENT0("android_webview", "InitializeHwDraw");
- hardware_failed_ = !compositor_->InitializeHwDraw();
- hardware_initialized_ = true;
- last_egl_context_ = current_context;
-
- if (hardware_failed_)
+ if (InitializeHwDraw())
+ last_egl_context_ = current_context;
+ else
return;
}
@@ -330,7 +338,6 @@ void InProcessViewRenderer::DrawGL(AwDrawGLInfo* draw_info) {
TRACE_EVENT_INSTANT0(
"android_webview", "EGLContextChanged", TRACE_EVENT_SCOPE_THREAD);
}
- last_egl_context_ = current_context;
if (!compositor_) {
TRACE_EVENT_INSTANT0(
@@ -338,21 +345,26 @@ void InProcessViewRenderer::DrawGL(AwDrawGLInfo* draw_info) {
return;
}
+ DCHECK(gl_surface_);
+ gl_surface_->SetBackingFrameBufferObject(
+ state_restore.framebuffer_binding_ext());
+
gfx::Transform transform;
transform.matrix().setColMajorf(draw_info->transform);
transform.Translate(scroll_at_start_of_frame_.x(),
scroll_at_start_of_frame_.y());
- // TODO(joth): Check return value.
- block_invalidates_ = true;
gfx::Rect clip_rect(draw_info->clip_left,
draw_info->clip_top,
draw_info->clip_right - draw_info->clip_left,
draw_info->clip_bottom - draw_info->clip_top);
+ block_invalidates_ = true;
+ // TODO(joth): Check return value.
compositor_->DemandDrawHw(gfx::Size(draw_info->width, draw_info->height),
transform,
clip_rect,
state_restore.stencil_enabled());
block_invalidates_ = false;
+ gl_surface_->ResetBackingFrameBufferObject();
UpdateCachedGlobalVisibleRect();
bool drew_full_visible_rect = clip_rect.Contains(cached_global_visible_rect_);
@@ -552,6 +564,7 @@ void InProcessViewRenderer::OnDetachedFromWindow() {
ScopedAllowGL allow_gl;
compositor_->ReleaseHwDraw();
hardware_initialized_ = false;
+ gl_surface_ = NULL;
}
attached_to_window_ = false;

Powered by Google App Engine
This is Rietveld 408576698