ui/gl/android/surface_factory_webview.h - Issue 22277004: Add gfx::SurfaceFactoryWebview

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/android/surface_factory_webview.h

Issue 22277004: Add gfx::SurfaceFactoryWebview (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: implementation Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GL_ANDROID_SURFACE_FACTORY_WEBVIEW_H_

	6 #define UI_GL_ANDROID_SURFACE_FACTORY_WEBVIEW_H_

	7

	8 #include "base/memory/ref_counted.h"

	9 #include "ui/gl/gl_surface.h"

	10

	11 namespace gfx {

	12
	no sievers 2013/08/06 01:50:06 nit: fwd declare GLSurface nit: fwd declare GLSurface boliu 2013/08/06 02:14:26 That works?...wow, that works. Done. Show quoted text On 2013/08/06 01:50:06, sievers wrote: > nit: fwd declare GLSurface That works?...wow, that works. Done.
	13 class SurfaceFactoryWebView {

	14 public:

	15 virtual ~SurfaceFactoryWebView();
	no sievers 2013/08/06 01:50:06 nit: protected destructor nit: protected destructor boliu 2013/08/06 02:14:26 Done. Show quoted text On 2013/08/06 01:50:06, sievers wrote: > nit: protected destructor Done.
	16

	17 static SurfaceFactoryWebView* GetInstance();

	18 static void SetInstance(SurfaceFactoryWebView* instance);

	19

	20 virtual scoped_refptr<GLSurface> CreateNonOwnedViewSurface() = 0;

	21 };

	22

	23 } // namespace gfx

	24

	25 #endif // UI_GL_ANDROID_SURFACE_FACTORY_WEBVIEW_H_

OLD	NEW