Add gfx::SurfaceFactoryWebview

android_webview/browser/gl_surface_factory.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/browser/gl_surface_factory.h"
+
+#include "base/lazy_instance.h"
+#include "ui/gl/gl_bindings.h"
+
+namespace android_webview {
+
+namespace {
+
+unsigned int g_current_fbo = 0;
+
+class GL_EXPORT AwGLSurface : public gfx::GLSurface {
+ public:
+  // Implement GLSurface.
+  virtual void Destroy() OVERRIDE;
+  virtual bool IsOffscreen() OVERRIDE;
+  virtual unsigned int GetBackingFrameBufferObject() OVERRIDE;
+  virtual bool SwapBuffers() OVERRIDE;
+  virtual gfx::Size GetSize() OVERRIDE;
+  virtual void* GetHandle() OVERRIDE;
+  virtual void* GetDisplay() OVERRIDE;
+
+ protected:
+  virtual ~AwGLSurface();
+};
+
+AwGLSurface::~AwGLSurface() {}
+
+/*
+*/
+
+void AwGLSurface::Destroy() {
+}
+
+bool AwGLSurface::IsOffscreen() {
+  return false;
+}
+
+unsigned int AwGLSurface::GetBackingFrameBufferObject() {
+  return g_current_fbo;
+}
+
+bool AwGLSurface::SwapBuffers() {
+  return true;
+}
+
+gfx::Size AwGLSurface::GetSize() {
+  return gfx::Size();
+}
+
+void* AwGLSurface::GetHandle() {
+  return NULL;
+}
+
+void* AwGLSurface::GetDisplay() {
+  return NULL;
+}
+
+base::LazyInstance<GLSurfaceFactory>::Leaky g_gl_surface_factory;
+
+}  // namespace
+
+// static
+void GLSurfaceFactory::Install() {
+  gfx::SurfaceFactoryWebView::SetInstance(g_gl_surface_factory.Pointer());

[no sievers, 2013/08/06 01:50:06]

do you need the LazyInstance (esp. since you are leaking it)? Or can it just be:
DCHECK(!gfx::SurfaceFactoryWebView::GetInstance());
gfx::SurfaceFactoryWebView::SetInstance(new GLSurfaceFactory());

[boliu, 2013/08/06 02:14:26]

For no particular reason other than it's a pattern with android_webview code. I
guess it makes the leaking part explicit.

Added the DCHECK though.

[joth, 2013/08/06 03:55:41]

we use Daniel's pattern too... see content::SetContentMainDelegate(new
android_webview::AwMainDelegate()); for example.

As AtExit manager is never run it's fairly moot which of the three patterns are
used.  I'm personally for the simplicity of what Daniel suggests for places like
this that we know will be called in early initialization when we're still single
threaded, and given we can assert the sington-ness of it easily.

+}
+
+// static
+void GLSurfaceFactory::SetCurrentFBO(unsigned int fbo) {
+  g_current_fbo = fbo;
+}
+
+GLSurfaceFactory::GLSurfaceFactory() {}
+
+GLSurfaceFactory::~GLSurfaceFactory() {}
+
+scoped_refptr<gfx::GLSurface> GLSurfaceFactory::CreateNonOwnedViewSurface() {
+  return new AwGLSurface;
+}
+
+}  // namespace android_webview