Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2227613002: [test] Deprecate test data download for most test suites (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Deprecate test data download for most test suites This removes the test-download method for all but promises-aplus. They all only contain legacy code for deleting old archives. Only test262 needs to prepare sources on swarming, which is moved to a new method, called unconditionally. All references to --download-data and --download-data-only in the infrastructure can be removed after this. BUG= Committed: https://crrev.com/a2a597239591d88d6c879261064d6ced7fe55932 Cr-Commit-Position: refs/heads/master@{#38439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -51 lines) Patch
M test/mozilla/testcfg.py View 2 chunks +0 lines, -17 lines 0 comments Download
M test/simdjs/testcfg.py View 2 chunks +0 lines, -16 lines 0 comments Download
M test/test262/testcfg.py View 2 chunks +1 line, -17 lines 0 comments Download
M tools/run-tests.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-08-08 11:29:16 UTC) #4
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-08 11:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227613002/1
4 years, 4 months ago (2016-08-08 12:37:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 12:39:06 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 12:39:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2a597239591d88d6c879261064d6ced7fe55932
Cr-Commit-Position: refs/heads/master@{#38439}

Powered by Google App Engine
This is Rietveld 408576698