Fix BGRA for ES3 RenderbufferStorageMultisample

Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
Committed: https://crrev.com/ad8b34b93f28c3c66417d9d15c110f4e77d0c97d
Cr-Commit-Position: refs/heads/master@{#410484}

[ericrk, 2016-08-08 20:32:44]

Description was changed from

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
==========

to

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
==========

[ericrk, 2016-08-08 20:32:44]

ericrk@chromium.org changed reviewers:
+ zmo@chromium.org

[ericrk, 2016-08-08 20:32:55]

ericrk@chromium.org changed reviewers:
+ kbr@chromium.org

[ericrk, 2016-08-08 20:34:38]

Here's the fix for ES3 BGRA - just makes ES3 do a BGRA > RGBA conversion like
ES2.

[Zhenyao Mo, 2016-08-08 20:40:55]

On 2016/08/08 20:34:38, ericrk wrote:
> Here's the fix for ES3 BGRA - just makes ES3 do a BGRA > RGBA conversion like
> ES2.

lgtm, but I am not an owner.

[Zhenyao Mo, 2016-08-08 20:41:00]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 20:41:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 20:52:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-08-08 20:55:21]

Ah, great. LGTM

[ericrk, 2016-08-08 21:00:55]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:01:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:16:28]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Russell (switch to Gerrit), 2016-08-08 21:30:09]

On 2016/08/08 21:16:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Oops, that looks like a legitimate problem in the code.

FAILED: obj/ui/gl/gl/gl_gl_api_implementation.obj 
ninja -t msvc -e environment.x64 -- E:\b\c\cipd\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC @obj/ui/gl/gl/gl_gl_api_implementation.obj.rsp /c
../../ui/gl/gl_gl_api_implementation.cc
/Foobj/ui/gl/gl/gl_gl_api_implementation.obj /Fd"obj/ui/gl/gl_cc.pdb"
e:\b\c\b\win\src\ui\gl\gl_gl_api_implementation.cc(321) : error C2220: warning
treated as error - no 'object' file generated
e:\b\c\b\win\src\ui\gl\gl_gl_api_implementation.cc(321) : warning C4706:
assignment within conditional expression

[ericrk, 2016-08-08 21:36:05]

On 2016/08/08 21:30:09, Ken Russell wrote:
> On 2016/08/08 21:16:28, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> 
> Oops, that looks like a legitimate problem in the code.
> 
> FAILED: obj/ui/gl/gl/gl_gl_api_implementation.obj 
> ninja -t msvc -e environment.x64 -- E:\b\c\cipd\goma/gomacc.exe
>
"E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe"
> /nologo /showIncludes /FC @obj/ui/gl/gl/gl_gl_api_implementation.obj.rsp /c
> ../../ui/gl/gl_gl_api_implementation.cc
> /Foobj/ui/gl/gl/gl_gl_api_implementation.obj /Fd"obj/ui/gl/gl_cc.pdb"
> e:\b\c\b\win\src\ui\gl\gl_gl_api_implementation.cc(321) : error C2220: warning
> treated as error - no 'object' file generated
> e:\b\c\b\win\src\ui\gl\gl_gl_api_implementation.cc(321) : warning C4706:
> assignment within conditional expression

whoops - my bad. Uploading fix.

[ericrk, 2016-08-08 21:37:09]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-08-08 21:37:10]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2227603003/#ps20001
(title: "change accidental "=" to "=="")

[commit-bot: I haz the power, 2016-08-08 21:37:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:46:06]

Description was changed from

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
==========

to

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
==========

[commit-bot: I haz the power, 2016-08-08 22:46:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 22:48:21]

Description was changed from

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659
==========

to

==========
Fix BGRA for ES3 RenderbufferStorageMultisample

When dealing with BGRA on desktop, we typically convert to RGBA at the
GL boundary. This was missing from the core profile function,
RenderbufferStorageMultisample. This CL adds the conversion logic, so
RenderbufferStorageMultisample lines up with the EXT version.

BUG=633659

Committed: https://crrev.com/ad8b34b93f28c3c66417d9d15c110f4e77d0c97d
Cr-Commit-Position: refs/heads/master@{#410484}
==========

[commit-bot: I haz the power, 2016-08-08 22:48:22]

Patchset 2 (id:??) landed as
https://crrev.com/ad8b34b93f28c3c66417d9d15c110f4e77d0c97d
Cr-Commit-Position: refs/heads/master@{#410484}