ServiceWorker: Implement StartWorker by using mojo

content/browser/service_worker/embedded_worker_instance.h

Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 116456b4528ccafdd3f830da61a1b9cce0df1b2f..1a19a56dbe6f546679b65e4684f634d0b9d85c48 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -23,6 +23,7 @@
 #include "content/browser/service_worker/embedded_worker_status.h"
 #include "content/browser/service_worker/service_worker_metrics.h"
 #include "content/common/content_export.h"
+#include "content/common/service_worker/embedded_worker.mojom.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 #include "content/public/common/console_message_level.h"
 #include "url/gurl.h"
@@ -32,8 +33,6 @@
 #undef SendMessage
 #endif
 
-struct EmbeddedWorkerMsg_StartWorker_Params;
-
 namespace IPC {
 class Message;
 }
@@ -46,6 +45,7 @@ class InterfaceRegistry;
 namespace content {
 
 class EmbeddedWorkerRegistry;
+struct EmbeddedWorkerStartParams;
 class MessagePortMessageFilter;
 class ServiceWorkerContextCore;
 
@@ -111,7 +111,7 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
   // started and evaluated, or when an error occurs.
   // |params| should be populated with service worker version info needed
   // to start the worker.
-  void Start(std::unique_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,
+  void Start(std::unique_ptr<EmbeddedWorkerStartParams> params,
              const StatusCallback& callback);
 
   // Stops the worker. It is invalid to call this when the worker is
@@ -223,6 +223,9 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
                                      int worker_devtools_agent_route_id,
                                      bool wait_for_debugger);
 
+  // Sends StartWorker message via Mojo.
+  void SendMojoStartWorker(std::unique_ptr<EmbeddedWorkerStartParams> params);
+
   // Called back from StartTask after a start worker message is sent.
   void OnStartWorkerMessageSent();
 
@@ -305,8 +308,14 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
   // Current running information.
   std::unique_ptr<EmbeddedWorkerInstance::WorkerProcessHandle> process_handle_;
   int thread_id_;
+
+  // Mojo endpoints. EmbeddedWorkerInstance has one client object on a
+  // renderer process. |interface_registry_| will be sent after a process has

[falken, 2016/09/13 05:48:02]

Maybe just "|client_| is used to send messages to the renderer process"?

[shimazu, 2016/09/15 03:24:42]

Done.

+  // been launched, and |remote_interfaces_| will be sent back to this object
+  // when the worker thread on the remote process gets ready for IPC.

[falken, 2016/09/13 05:48:02]

Thank you writing for the comments.

I'm confused what it means to send the interface_registry_ and
remote_interfaces_.

|interface_registry_| is sent to the renderer process after the worker thread
starts (in OnThreadStarted)?

|remote_interfaces_| is sent back by the renderer process when the worker thread
is ready for IPC?

[shimazu, 2016/09/15 03:24:42]

Sorry for confusing.
It's connected on EmbeddedWorkerSetup->ExchangeInterfaces() in this patch, and
InterfaceRegistry/Provider in this object will be connected at
StartWorker/AttachClientInterfaceProvider at https://crrev.com/2313653002 .
I wrote what will happen after https://crrev.com/2313653002 is landed by mistake
;(
I'll move this message to that CL.

   std::unique_ptr<shell::InterfaceRegistry> interface_registry_;
   std::unique_ptr<shell::InterfaceProvider> remote_interfaces_;
+  mojom::EmbeddedWorkerInstanceClientPtr client_;
 
   // Whether devtools is attached or not.
   bool devtools_attached_;