Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2227593002: ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added argument check and updated comment and BUILD.gn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc
diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..89b9612837853b74f90ccdb976f4caf51523620c
--- /dev/null
+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
@@ -0,0 +1,77 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/service_worker/embedded_worker_instance_client_impl.h"
+
+#include <memory>
+
+#include "base/strings/utf_string_conversions.h"
+#include "content/child/scoped_child_process_reference.h"
+#include "content/common/service_worker/embedded_worker_messages.h"
+#include "content/public/common/content_client.h"
+#include "content/renderer/service_worker/embedded_worker_devtools_agent.h"
+#include "content/renderer/service_worker/service_worker_context_client.h"
+#include "third_party/WebKit/public/web/WebEmbeddedWorker.h"
+#include "third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h"
+
+namespace content {
+
+// static
+void EmbeddedWorkerInstanceClientImpl::Create(
+ EmbeddedWorkerDispatcher* dispatcher,
+ mojo::InterfaceRequest<mojom::EmbeddedWorkerInstanceClient> request) {
+ new EmbeddedWorkerInstanceClientImpl(dispatcher, std::move(request));
+}
+
+void EmbeddedWorkerInstanceClientImpl::StartWorker(
dcheng 2016/09/07 07:51:09 I guess this is based on the existing SW code? Wil
shimazu 2016/09/12 06:28:20 Yes, actually. Moved the shared codes into EWDispa
+ mojom::EmbeddedWorkerStartWorkerParamsPtr params) {
+ TRACE_EVENT0("ServiceWorker",
+ "EmbeddedWorkerInstanceClientImpl::StartWorker");
+
+ std::unique_ptr<EmbeddedWorkerDispatcher::WorkerWrapper> wrapper(
+ new EmbeddedWorkerDispatcher::WorkerWrapper(
+ blink::WebEmbeddedWorker::create(
+ new ServiceWorkerContextClient(
+ params->embedded_worker_id, params->service_worker_version_id,
+ params->scope, params->script_url,
+ params->worker_devtools_agent_route_id),
+ NULL),
+ params->worker_devtools_agent_route_id));
+
+ blink::WebEmbeddedWorkerStartData start_data;
+ start_data.scriptURL = params->script_url;
dcheng 2016/09/07 07:51:09 Let's add a typemap for this instead of using nati
shimazu 2016/09/12 06:28:19 I tried to use the typemap, but I'm not certain ab
dcheng 2016/09/21 08:21:17 Yes, you're right, that would be the right time to
+ start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());
+ start_data.waitForDebuggerMode =
+ params->wait_for_debugger
+ ? blink::WebEmbeddedWorkerStartData::WaitForDebugger
+ : blink::WebEmbeddedWorkerStartData::DontWaitForDebugger;
+ start_data.v8CacheOptions = static_cast<blink::WebSettings::V8CacheOptions>(
+ params->settings->v8_cache_options);
+ start_data.dataSaverEnabled = params->settings->data_saver_enabled;
+ start_data.pauseAfterDownloadMode =
+ params->pause_after_download
+ ? blink::WebEmbeddedWorkerStartData::PauseAfterDownload
+ : blink::WebEmbeddedWorkerStartData::DontPauseAfterDownload;
+
+ wrapper->worker()->startWorkerContext(start_data);
+ wrapper_ = wrapper.get();
+ dispatcher_->RegisterWorker(params->embedded_worker_id, std::move(wrapper));
+}
+
+EmbeddedWorkerInstanceClientImpl::EmbeddedWorkerInstanceClientImpl(
+ EmbeddedWorkerDispatcher* dispatcher,
+ mojo::InterfaceRequest<mojom::EmbeddedWorkerInstanceClient> request)
+ : dispatcher_(dispatcher), binding_(this, std::move(request)) {
+ binding_.set_connection_error_handler(base::Bind(
+ &EmbeddedWorkerInstanceClientImpl::OnError, base::Unretained(this)));
+}
+
+EmbeddedWorkerInstanceClientImpl::~EmbeddedWorkerInstanceClientImpl() {}
+
+void EmbeddedWorkerInstanceClientImpl::OnError() {
+ // TODO(shimazu): Implement here
+ DVLOG(2) << __FUNCTION__;
falken 2016/09/07 05:01:42 NOTIMPLEMENTED()
shimazu 2016/09/12 06:28:20 Done.
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698