content/common/service_worker/embedded_worker.mojom - Issue 2227593002: ServiceWorker: Implement StartWorker by using mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/service_worker/embedded_worker.mojom

Issue 2227593002: ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initialized StartParams Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module media.mojom;	5 module content.mojom;

6	6

7 import "media/mojo/interfaces/service_factory.mojom";

8 import "services/shell/public/interfaces/interface_provider.mojom";	7 import "services/shell/public/interfaces/interface_provider.mojom";

	8 import "url/mojo/url.mojom";

9	9

10 interface MediaService {	10 [Native]

11 CreateServiceFactory(ServiceFactory& factory,	11 struct EmbeddedWorkerStartParams;

12 shell.mojom.InterfaceProvider frame_interfaces);	12

	13 interface EmbeddedWorkerInstanceClient {
	falken 2016/09/13 05:48:02 Can you add some lightweight documentation? I'm lo Can you add some lightweight documentation? I'm looking at chrome/src/ash/public/interfaces/wallpaper.mojom or shelf.mojom as an example (when in doubt ash/ tends to have clean modern code) shimazu 2016/09/15 03:24:42 Done. Show quoted text On 2016/09/13 05:48:02, falken wrote: > Can you add some lightweight documentation? I'm looking at > chrome/src/ash/public/interfaces/wallpaper.mojom or shelf.mojom as an example > (when in doubt ash/ tends to have clean modern code) Done.
	14 StartWorker(EmbeddedWorkerStartParams params);

13 };	15 };

OLD	NEW