third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

index 1dad51b3dc47b2dcfcc74f5d8027052252d536d0..03218dd2171a00f6d4656e6f6ae730e24317618a 100644

--- a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

@@ -435,7 +435,7 @@ TEST(WebInputEventConversionTest, InputEventsScaling)

// Reverse builders should *not* go back to physical pixels, as they are used for plugins

// which expect CSS pixel coordinates.

{

- PlatformMouseEvent platformMouseEvent(IntPoint(10, 10), IntPoint(10, 10), LeftButton, PlatformEvent::MouseMoved, 1, PlatformEvent::NoModifiers, PlatformMouseEvent::RealOrIndistinguishable, 0);

+ PlatformMouseEvent platformMouseEvent(IntPoint(10, 10), IntPoint(10, 10), WebPointerProperties::Button::Left, PlatformEvent::MouseMoved, 1, PlatformEvent::NoModifiers, PlatformMouseEvent::RealOrIndistinguishable, 0);

MouseEvent* mouseEvent = MouseEvent::create(EventTypeNames::mousemove, domWindow, platformMouseEvent, 0, document);

WebMouseEventBuilder webMouseBuilder(view, documentLayoutView, *mouseEvent);

@@ -448,10 +448,10 @@ TEST(WebInputEventConversionTest, InputEventsScaling)

}

{

- PlatformMouseEvent platformMouseEvent(IntPoint(10, 10), IntPoint(10, 10), NoButton, PlatformEvent::MouseMoved, 1, PlatformEvent::NoModifiers, PlatformMouseEvent::RealOrIndistinguishable, 0);

+ PlatformMouseEvent platformMouseEvent(IntPoint(10, 10), IntPoint(10, 10), WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 1, PlatformEvent::NoModifiers, PlatformMouseEvent::RealOrIndistinguishable, 0);

MouseEvent* mouseEvent = MouseEvent::create(EventTypeNames::mousemove, domWindow, platformMouseEvent, 0, document);

WebMouseEventBuilder webMouseBuilder(view, documentLayoutView, *mouseEvent);

- EXPECT_EQ(WebMouseEvent::ButtonNone, webMouseBuilder.button);

+ EXPECT_EQ(WebMouseEvent::Button::NoButton, webMouseBuilder.button);

}

{