Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new instances Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 9bc4335ce6d61d0e6cfa6575c8a292b7bff37569..6d49474a82eded6aa0de7bbb54d9341e27a2f48f 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -532,7 +532,7 @@ void WebViewImpl::handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent& ev
// (outside of the popup). We also save it so we can prevent a click on an
// element from immediately reopening the same popup.
RefPtr<WebPagePopupImpl> pagePopup;
- if (event.button == WebMouseEvent::ButtonLeft) {
+ if (event.button == WebMouseEvent::Button::Left) {
pagePopup = m_pagePopup;
hidePopups();
DCHECK(!m_pagePopup);
@@ -542,7 +542,7 @@ void WebViewImpl::handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent& ev
// If the hit node is a plugin but a scrollbar is over it don't start mouse
// capture because it will interfere with the scrollbar receiving events.
IntPoint point(event.x, event.y);
- if (event.button == WebMouseEvent::ButtonLeft && m_page->mainFrame()->isLocalFrame()) {
+ if (event.button == WebMouseEvent::Button::Left && m_page->mainFrame()->isLocalFrame()) {
point = m_page->deprecatedLocalMainFrame()->view()->rootFrameToContents(point);
HitTestResult result(m_page->deprecatedLocalMainFrame()->eventHandler().hitTestResultAtPoint(point));
result.setToShadowHostIfInUserAgentShadowRoot();
@@ -556,7 +556,7 @@ void WebViewImpl::handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent& ev
PageWidgetEventHandler::handleMouseDown(mainFrame, event);
- if (event.button == WebMouseEvent::ButtonLeft && m_mouseCaptureNode)
+ if (event.button == WebMouseEvent::Button::Left && m_mouseCaptureNode)
m_mouseCaptureGestureToken = mainFrame.eventHandler().takeLastMouseDownGestureToken();
if (m_pagePopup && pagePopup && m_pagePopup->hasSamePopupClient(pagePopup.get())) {
@@ -568,12 +568,12 @@ void WebViewImpl::handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent& ev
// Dispatch the contextmenu event regardless of if the click was swallowed.
if (!page()->settings().showContextMenuOnMouseUp()) {
#if OS(MACOSX)
- if (event.button == WebMouseEvent::ButtonRight
- || (event.button == WebMouseEvent::ButtonLeft
+ if (event.button == WebMouseEvent::Button::Right
+ || (event.button == WebMouseEvent::Button::Left
&& event.modifiers & WebMouseEvent::ControlKey))
mouseContextMenu(event);
#else
- if (event.button == WebMouseEvent::ButtonRight)
+ if (event.button == WebMouseEvent::Button::Right)
mouseContextMenu(event);
#endif
}
@@ -629,7 +629,7 @@ void WebViewImpl::handleMouseUp(LocalFrame& mainFrame, const WebMouseEvent& even
if (page()->settings().showContextMenuOnMouseUp()) {
// Dispatch the contextmenu event regardless of if the click was swallowed.
// On Mac/Linux, we handle it on mouse down, not up.
- if (event.button == WebMouseEvent::ButtonRight)
+ if (event.button == WebMouseEvent::Button::Right)
mouseContextMenu(event);
}
}
@@ -3647,7 +3647,7 @@ void WebViewImpl::dragSourceEndedAt(
const WebPoint& screenPoint,
WebDragOperation operation)
{
- PlatformMouseEvent pme(clientPoint, screenPoint, LeftButton, PlatformEvent::MouseMoved,
+ PlatformMouseEvent pme(clientPoint, screenPoint, WebPointerProperties::Button::Left, PlatformEvent::MouseMoved,
0, PlatformEvent::NoModifiers, PlatformMouseEvent::RealOrIndistinguishable, WTF::monotonicallyIncreasingTime());
m_page->deprecatedLocalMainFrame()->eventHandler().dragSourceEndedAt(pme,
static_cast<DragOperation>(operation));

Powered by Google App Engine
This is Rietveld 408576698