third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index 46f57714d851fec3a64537ee81f4247643f91028..5bc5f0c0430b88abadca6dcb4d599391da9250e2 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -1141,7 +1141,7 @@ EventDispatchHandlingState* HTMLInputElement::preDispatchEventHandler(Event* eve

}

if (event->type() != EventTypeNames::click)

return nullptr;

- if (!event->isMouseEvent() || toMouseEvent(event)->button() != LeftButton)

+ if (!event->isMouseEvent() || toMouseEvent(event)->button() != static_cast<short>(WebPointerProperties::Button::Left))

return nullptr;

return m_inputTypeView->willDispatchClick();

}

@@ -1155,7 +1155,7 @@ void HTMLInputElement::postDispatchEventHandler(Event* event, EventDispatchHandl

void HTMLInputElement::defaultEventHandler(Event* evt)

{

- if (evt->isMouseEvent() && evt->type() == EventTypeNames::click && toMouseEvent(evt)->button() == LeftButton) {

+ if (evt->isMouseEvent() && evt->type() == EventTypeNames::click && toMouseEvent(evt)->button() == static_cast<short>(WebPointerProperties::Button::Left)) {

m_inputTypeView->handleClickEvent(toMouseEvent(evt));

if (evt->defaultHandled())

return;