content/renderer/webscrollbarbehavior_impl_mac.mm - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/webscrollbarbehavior_impl_mac.mm

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/webscrollbarbehavior_impl_mac.mm

diff --git a/content/renderer/webscrollbarbehavior_impl_mac.mm b/content/renderer/webscrollbarbehavior_impl_mac.mm

index 9f83f8a3de325f7fa9e04001d264f47a893c1f10..13d2ef055a9c8e5f5f5d5d7d18c170c0b18e77d5 100644

--- a/content/renderer/webscrollbarbehavior_impl_mac.mm

+++ b/content/renderer/webscrollbarbehavior_impl_mac.mm

@@ -11,10 +11,10 @@ WebScrollbarBehaviorImpl::WebScrollbarBehaviorImpl()

}

bool WebScrollbarBehaviorImpl::shouldCenterOnThumb(

- blink::WebScrollbarBehavior::Button mouseButton,

+ blink::WebPointerProperties::Button mouseButton,

bool shiftKeyPressed,

bool altKeyPressed) {

- return (mouseButton == blink::WebScrollbarBehavior::ButtonLeft) &&

+ return (mouseButton == blink::WebPointerProperties::Button::Left) &&

(jump_on_track_click_ != altKeyPressed);

}