Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_mac.mm

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new instances Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/web_input_event_builders_mac.mm
diff --git a/content/browser/renderer_host/input/web_input_event_builders_mac.mm b/content/browser/renderer_host/input/web_input_event_builders_mac.mm
index 91b761d1ced1467c53cea560cc589ee15af69378..2b6c0fb416cf91096303dd9767bdc4bcbc0b0709 100644
--- a/content/browser/renderer_host/input/web_input_event_builders_mac.mm
+++ b/content/browser/renderer_host/input/web_input_event_builders_mac.mm
@@ -336,37 +336,37 @@ blink::WebMouseEvent WebMouseEventBuilder::Build(NSEvent* event, NSView* view) {
switch (type) {
case NSMouseExited:
result.type = blink::WebInputEvent::MouseLeave;
- result.button = blink::WebMouseEvent::ButtonNone;
+ result.button = blink::WebMouseEvent::Button::NoButton;
break;
case NSLeftMouseDown:
result.type = blink::WebInputEvent::MouseDown;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonLeft;
+ result.button = blink::WebMouseEvent::Button::Left;
break;
case NSOtherMouseDown:
result.type = blink::WebInputEvent::MouseDown;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonMiddle;
+ result.button = blink::WebMouseEvent::Button::Middle;
break;
case NSRightMouseDown:
result.type = blink::WebInputEvent::MouseDown;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonRight;
+ result.button = blink::WebMouseEvent::Button::Right;
break;
case NSLeftMouseUp:
result.type = blink::WebInputEvent::MouseUp;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonLeft;
+ result.button = blink::WebMouseEvent::Button::Left;
break;
case NSOtherMouseUp:
result.type = blink::WebInputEvent::MouseUp;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonMiddle;
+ result.button = blink::WebMouseEvent::Button::Middle;
break;
case NSRightMouseUp:
result.type = blink::WebInputEvent::MouseUp;
result.clickCount = [event clickCount];
- result.button = blink::WebMouseEvent::ButtonRight;
+ result.button = blink::WebMouseEvent::Button::Right;
break;
case NSMouseMoved:
case NSMouseEntered:
@@ -374,15 +374,15 @@ blink::WebMouseEvent WebMouseEventBuilder::Build(NSEvent* event, NSView* view) {
break;
case NSLeftMouseDragged:
result.type = blink::WebInputEvent::MouseMove;
- result.button = blink::WebMouseEvent::ButtonLeft;
+ result.button = blink::WebMouseEvent::Button::Left;
break;
case NSOtherMouseDragged:
result.type = blink::WebInputEvent::MouseMove;
- result.button = blink::WebMouseEvent::ButtonMiddle;
+ result.button = blink::WebMouseEvent::Button::Middle;
break;
case NSRightMouseDragged:
result.type = blink::WebInputEvent::MouseMove;
- result.button = blink::WebMouseEvent::ButtonRight;
+ result.button = blink::WebMouseEvent::Button::Right;
break;
default:
NOTIMPLEMENTED();
@@ -424,7 +424,7 @@ blink::WebMouseWheelEvent WebMouseWheelEventBuilder::Build(
blink::WebMouseWheelEvent result;
result.type = blink::WebInputEvent::MouseWheel;
- result.button = blink::WebMouseEvent::ButtonNone;
+ result.button = blink::WebMouseEvent::Button::NoButton;
result.modifiers = ModifiersFromEvent(event);

Powered by Google App Engine
This is Rietveld 408576698