third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index af5a8d2bd14acb9b3e5915ea1186c7a95963119a..517be6b2cdd123e78831e3ff0757cf5b9fb8bb03 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -537,13 +537,13 @@ static bool allowCreatingBackgroundTabs()

const WebMouseEvent* mouseEvent = static_cast<const WebMouseEvent*>(inputEvent);

switch (mouseEvent->button) {

- case WebMouseEvent::ButtonLeft:

+ case WebMouseEvent::Button::Left:

buttonNumber = 0;

break;

- case WebMouseEvent::ButtonMiddle:

+ case WebMouseEvent::Button::Middle:

buttonNumber = 1;

break;

- case WebMouseEvent::ButtonRight:

+ case WebMouseEvent::Button::Right:

buttonNumber = 2;

break;

default: