third_party/WebKit/Source/core/dom/Node.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 8887dc3c9ad1bbcd71139232797e17c2ce296b75..a24483a33a90a1e2e1c3d89275e2aae6845bf2e2 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -2088,7 +2088,7 @@ void Node::defaultEventHandler(Event* event)

#if OS(WIN)

} else if (eventType == EventTypeNames::mousedown && event->isMouseEvent()) {

MouseEvent* mouseEvent = toMouseEvent(event);

- if (mouseEvent->button() == MiddleButton) {

+ if (mouseEvent->button() == static_cast<short>(WebPointerProperties::Button::Middle)) {

if (enclosingLinkEventParentOrSelf())

return;