content/browser/devtools/protocol/color_picker.cc - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/color_picker.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/color_picker.cc

diff --git a/content/browser/devtools/protocol/color_picker.cc b/content/browser/devtools/protocol/color_picker.cc

index 3016caf9b34d62a4bbefe86b75dda5d6e5f238c4..21f5c3d235432ccba8fb282bdaa47e83a5eda704 100644

--- a/content/browser/devtools/protocol/color_picker.cc

+++ b/content/browser/devtools/protocol/color_picker.cc

@@ -115,7 +115,7 @@ bool ColorPicker::HandleMouseEvent(const blink::WebMouseEvent& event) {

if (frame_.drawsNothing())

return true;

- if (event.button == blink::WebMouseEvent::ButtonLeft &&

+ if (event.button == blink::WebMouseEvent::Button::Left &&

event.type == blink::WebInputEvent::MouseDown) {

if (last_cursor_x_ < 0 || last_cursor_x_ >= frame_.width() ||

last_cursor_y_ < 0 || last_cursor_y_ >= frame_.height()) {