chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | third_party/WebKit/Source/core/events/PointerEventFactory.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index 2a0b558d6ca70d607c735c9d2411de9dd9be9e5f..372cb8e30916035ab0f1e2e2d3ab109525104e98 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -560,7 +560,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, RequestOpenTab) {

// There's a link on a.html. Middle-click on it to open it in a new tab.

blink::WebMouseEvent mouse_event;

mouse_event.type = blink::WebInputEvent::MouseDown;

- mouse_event.button = blink::WebMouseEvent::ButtonMiddle;

+ mouse_event.button = blink::WebMouseEvent::Button::Middle;

mouse_event.x = 7;

mouse_event.y = 7;

mouse_event.clickCount = 1;

@@ -592,7 +592,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, TargetBlank) {

// new tab.

blink::WebMouseEvent mouse_event;

mouse_event.type = blink::WebInputEvent::MouseDown;

- mouse_event.button = blink::WebMouseEvent::ButtonLeft;

+ mouse_event.button = blink::WebMouseEvent::Button::Left;

mouse_event.x = 7;

mouse_event.y = 7;

mouse_event.clickCount = 1;

@@ -622,7 +622,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, TargetBlankIncognito) {

// new tab.

blink::WebMouseEvent mouse_event;

mouse_event.type = blink::WebInputEvent::MouseDown;

- mouse_event.button = blink::WebMouseEvent::ButtonLeft;

+ mouse_event.button = blink::WebMouseEvent::Button::Left;

mouse_event.x = 7;

mouse_event.y = 7;

mouse_event.clickCount = 1;