Refactoring button field and its type

third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/Range.h"
 #include "core/frame/FrameView.h"
 #include "core/input/EventHandler.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/ContextMenuController.h"
 #include "core/page/FocusController.h"
@@ skipping 34 matching lines @@
     String getSelectionText();
 
     FrameTestHelpers::WebViewHelper m_helper;
     WebViewImpl* m_webView = nullptr;
     Persistent<WebLocalFrameImpl> m_mainFrame = nullptr;
 };
 
 void LinkSelectionTestBase::emulateMouseDrag(const IntPoint& downPoint, const IntPoint& upPoint, int modifiers, DragFlags dragFlags)
 {
     if (dragFlags & SendDownEvent) {
-        const auto& downEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseDown, WebMouseEvent::ButtonLeft, downPoint, modifiers);
+        const auto& downEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseDown, WebMouseEvent::Button::Left, downPoint, modifiers);
         m_webView->handleInputEvent(downEvent);
     }
 
     const int kMoveEventsNumber = 10;
     const float kMoveIncrementFraction = 1. / kMoveEventsNumber;
     const auto& upDownVector = upPoint - downPoint;
     for (int i = 0; i < kMoveEventsNumber; ++i) {
         const auto& movePoint = downPoint + scaled(upDownVector, i * kMoveIncrementFraction);
-        const auto& moveEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseMove, WebMouseEvent::ButtonLeft, movePoint, modifiers);
+        const auto& moveEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseMove, WebMouseEvent::Button::Left, movePoint, modifiers);
         m_webView->handleInputEvent(moveEvent);
     }
 
     if (dragFlags & SendUpEvent) {
-        const auto& upEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseUp, WebMouseEvent::ButtonLeft, upPoint, modifiers);
+        const auto& upEvent = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseUp, WebMouseEvent::Button::Left, upPoint, modifiers);
         m_webView->handleInputEvent(upEvent);
     }
 }
 
 void LinkSelectionTestBase::emulateMouseClick(const IntPoint& clickPoint, WebMouseEvent::Button button, int modifiers, int count)
 {
     auto event = FrameTestHelpers::createMouseEvent(WebMouseEvent::MouseDown, button, clickPoint, modifiers);
     event.clickCount = count;
     m_webView->handleInputEvent(event);
     event.type = WebMouseEvent::MouseUp;
@@ skipping 88 matching lines @@
     EXPECT_EQ(Cursor::IBeam, cursor.getType());
 }
 
 TEST_F(LinkSelectionTest, HandCursorOverLinkAfterContextMenu)
 {
     // Move mouse.
     emulateMouseDrag(m_rightPointInLink, m_leftPointInLink, 0, 0);
 
     // Show context menu. We don't send mouseup event here since in browser it doesn't reach
     // blink because of shown context menu.
-    emulateMouseDown(m_leftPointInLink, WebMouseEvent::ButtonRight, 0, 1);
+    emulateMouseDown(m_leftPointInLink, WebMouseEvent::Button::Right, 0, 1);
 
     LocalFrame* frame = m_mainFrame->frame();
     // Hide context menu.
     frame->page()->contextMenuController().clearContextMenu();
 
     frame->localFrameRoot()->eventHandler().scheduleCursorUpdate();
     testing::runDelayedTasks(50);
     const auto& cursor = m_mainFrame->frame()->chromeClient().lastSetCursorForTesting();
     EXPECT_EQ(Cursor::Hand, cursor.getType());
 }
 
 TEST_F(LinkSelectionTest, SingleClickWithAltStartsDownload)
 {
     EXPECT_CALL(m_testFrameClient, loadURLExternally(_, WebNavigationPolicy::WebNavigationPolicyDownload, WebString(), _));
-    emulateMouseClick(m_leftPointInLink, WebMouseEvent::ButtonLeft, WebInputEvent::AltKey);
+    emulateMouseClick(m_leftPointInLink, WebMouseEvent::Button::Left, WebInputEvent::AltKey);
 }
 
 TEST_F(LinkSelectionTest, SingleClickWithAltStartsDownloadWhenTextSelected)
 {
     auto* document = m_mainFrame->frame()->document();
     auto* textToSelect = document->getElementById("page_text")->firstChild();
     ASSERT_NE(nullptr, textToSelect);
 
     // Select some page text outside the link element.
     const Range* rangeToSelect = Range::create(*document, textToSelect, 1, textToSelect, 20);
     const auto& selectionRect = rangeToSelect->boundingBox();
     m_mainFrame->moveRangeSelection(selectionRect.minXMinYCorner(), selectionRect.maxXMaxYCorner());
     EXPECT_FALSE(getSelectionText().isEmpty());
 
     EXPECT_CALL(m_testFrameClient, loadURLExternally(_, WebNavigationPolicy::WebNavigationPolicyDownload, WebString(), _));
-    emulateMouseClick(m_leftPointInLink, WebMouseEvent::ButtonLeft, WebInputEvent::AltKey);
+    emulateMouseClick(m_leftPointInLink, WebMouseEvent::Button::Left, WebInputEvent::AltKey);
 }
 
 class LinkSelectionClickEventsTest : public LinkSelectionTestBase {
 protected:
     class MockEventListener final : public EventListener {
     public:
         static MockEventListener* create()
         {
             return new MockEventListener();
         }
@@ skipping 48 matching lines @@
         MockEventListener* eventHandler = MockEventListener::create();
         element.addEventListener(
             doubleClickEvent ? EventTypeNames::dblclick : EventTypeNames::click,
             eventHandler);
 
         ::testing::InSequence s;
         EXPECT_CALL(*eventHandler, handleEvent(_, _)).Times(1);
 
         const auto& elemBounds = element.boundsInViewport();
         const int clickCount = doubleClickEvent ? 2 : 1;
-        emulateMouseClick(elemBounds.center(), WebMouseEvent::ButtonLeft, 0, clickCount);
+        emulateMouseClick(elemBounds.center(), WebMouseEvent::Button::Left, 0, clickCount);
 
         if (doubleClickEvent) {
             EXPECT_EQ(element.innerText().isEmpty(), getSelectionText().isEmpty());
         }
     }
 };
 
 TEST_F(LinkSelectionClickEventsTest, SingleAndDoubleClickWillBeHandled)
 {
     auto* document = m_mainFrame->frame()->document();
@@ skipping 16 matching lines @@
         checkMouseClicks(*element, false);
     }
 
     {
         SCOPED_TRACE("Text div, double click");
         checkMouseClicks(*element, true);
     }
 }
 
 } // namespace blink