Refactoring button field and its type

third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann <hausmann@kde.org>
  * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 46 matching lines @@
 private:
     explicit NavigationHintSender(HTMLAnchorElement*);
     bool shouldSendNavigationHint() const;
     void maybeSendNavigationHint(WebNavigationHintType);
 
     Member<HTMLAnchorElement> m_anchorElement;
 };
 
 void HTMLAnchorElement::NavigationHintSender::handleEvent(Event* event)
 {
-    if (event->type() == EventTypeNames::mousedown && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton)
+    if (event->type() == EventTypeNames::mousedown && event->isMouseEvent() && toMouseEvent(event)->button() == static_cast<short>(WebPointerProperties::Button::Left))
         maybeSendNavigationHint(WebNavigationHintType::LinkMouseDown);
     else if (event->type() == EventTypeNames::gesturetapunconfirmed)
         maybeSendNavigationHint(WebNavigationHintType::LinkTapUnconfirmed);
     else if (event->type() == EventTypeNames::gestureshowpress)
         maybeSendNavigationHint(WebNavigationHintType::LinkTapDown);
 }
 
 DEFINE_TRACE(HTMLAnchorElement::NavigationHintSender)
 {
     visitor->trace(m_anchorElement);
@@ skipping 370 matching lines @@
 }
 
 bool isEnterKeyKeydownEvent(Event* event)
 {
     return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->key() == "Enter" && !toKeyboardEvent(event)->repeat();
 }
 
 bool isLinkClick(Event* event)
 {
     // Allow detail <= 1 so that synthetic clicks work. They may have detail == 0.
-    return (event->type() == EventTypeNames::click || event->type() == EventTypeNames::auxclick) && (!event->isMouseEvent() || (toMouseEvent(event)->button() != RightButton && toMouseEvent(event)->detail() <= 1));
+    return (event->type() == EventTypeNames::click || event->type() == EventTypeNames::auxclick) && (!event->isMouseEvent() || (toMouseEvent(event)->button() != static_cast<short>(WebPointerProperties::Button::Right) && toMouseEvent(event)->detail() <= 1));
 }
 
 bool HTMLAnchorElement::willRespondToMouseClickEvents()
 {
     return isLink() || HTMLElement::willRespondToMouseClickEvents();
 }
 
 bool HTMLAnchorElement::isInteractiveContent() const
 {
     return isLink();
 }
 
 Node::InsertionNotificationRequest HTMLAnchorElement::insertedInto(ContainerNode* insertionPoint)
 {
     InsertionNotificationRequest request = HTMLElement::insertedInto(insertionPoint);
     logAddElementIfIsolatedWorldAndInDocument("a", hrefAttr);
     return request;
 }
 
 HTMLAnchorElement::NavigationHintSender* HTMLAnchorElement::ensureNavigationHintSender()
 {
     if (!m_navigationHintSender)
         m_navigationHintSender = NavigationHintSender::create(this);
     return m_navigationHintSender;
 }
 
 } // namespace blink