Refactoring button field and its type

third_party/WebKit/Source/core/events/MouseEvent.cpp

 /*
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "core/events/MouseEvent.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/Element.h"
 #include "core/events/EventDispatcher.h"
 #include "platform/PlatformMouseEvent.h"
+#include "public/platform/WebPointerProperties.h"
 
 namespace blink {
 
 MouseEvent* MouseEvent::create(ScriptState* scriptState, const AtomicString& type, const MouseEventInit& initializer)
 {
     if (scriptState && scriptState->world().isIsolatedWorld())
         UIEventWithKeyState::didCreateEventInIsolatedWorld(initializer.ctrlKey(), initializer.altKey(), initializer.shiftKey(), initializer.metaKey());
     return new MouseEvent(type, initializer);
 }
 
 MouseEvent* MouseEvent::create(const AtomicString& eventType, AbstractView* view, const PlatformMouseEvent& event, int detail, Node* relatedTarget)
 {
-    ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);
+    DCHECK(event.type() == PlatformEvent::MouseMoved || event.pointerProperties().button != WebPointerProperties::Button::NoButton);
 
     bool isMouseEnterOrLeave = eventType == EventTypeNames::mouseenter || eventType == EventTypeNames::mouseleave;
     bool isCancelable = !isMouseEnterOrLeave;
     bool isBubbling = !isMouseEnterOrLeave;
 
     return MouseEvent::create(
         eventType, isBubbling, isCancelable, view,
         detail, event.globalPosition().x(), event.globalPosition().y(), event.position().x(), event.position().y(),
         event.movementDelta().x(), event.movementDelta().y(),
-        event.getModifiers(), event.button(),
+        event.getModifiers(), static_cast<short>(event.pointerProperties().button),
         platformModifiersToButtons(event.getModifiers()),
         relatedTarget, event.timestamp(), event.getSyntheticEventType(), event.region());
 }
 
 MouseEvent* MouseEvent::create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
     int detail, int screenX, int screenY, int windowX, int windowY,
     int movementX, int movementY,
     PlatformEvent::Modifiers modifiers,
     short button, unsigned short buttons,
     EventTarget* relatedTarget,
@@ skipping 90 matching lines @@
     if (modifiers & PlatformEvent::LeftButtonDown)
         buttons |= static_cast<unsigned short>(Buttons::Left);
     if (modifiers & PlatformEvent::RightButtonDown)
         buttons |= static_cast<unsigned short>(Buttons::Right);
     if (modifiers & PlatformEvent::MiddleButtonDown)
         buttons |= static_cast<unsigned short>(Buttons::Middle);
 
     return buttons;
 }
 
-unsigned short MouseEvent::buttonToButtons(short button)
-{
-    switch (button) {
-    case NoButton:
-        return static_cast<unsigned short>(Buttons::None);
-    case LeftButton:
-        return static_cast<unsigned short>(Buttons::Left);
-    case RightButton:
-        return static_cast<unsigned short>(Buttons::Right);
-    case MiddleButton:
-        return static_cast<unsigned short>(Buttons::Middle);
-    }
-    ASSERT_NOT_REACHED();
-    return 0;
-}
-
 void MouseEvent::initMouseEvent(ScriptState* scriptState, const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
                                 int detail, int screenX, int screenY, int clientX, int clientY,
                                 bool ctrlKey, bool altKey, bool shiftKey, bool metaKey,
                                 short button, EventTarget* relatedTarget, unsigned short buttons)
 {
     if (isBeingDispatched())
         return;
 
     if (scriptState && scriptState->world().isIsolatedWorld())
         UIEventWithKeyState::didCreateEventInIsolatedWorld(ctrlKey, altKey, shiftKey, metaKey);
@@ skipping 88 matching lines @@
 
     if (!mouseEvent.isTrusted())
         return dispatcher.dispatch();
 
     if (isDisabledFormControl(&dispatcher.node()))
         return DispatchEventResult::CanceledBeforeDispatch;
 
     if (mouseEvent.type().isEmpty())
         return DispatchEventResult::NotCanceled; // Shouldn't happen.
 
-    ASSERT(!mouseEvent.target() || mouseEvent.target() != mouseEvent.relatedTarget());
+    DCHECK(!mouseEvent.target() || mouseEvent.target() != mouseEvent.relatedTarget());
 
     EventTarget* relatedTarget = mouseEvent.relatedTarget();
 
     DispatchEventResult dispatchResult = dispatcher.dispatch();
 
     if (mouseEvent.type() != EventTypeNames::click || mouseEvent.detail() != 2)
         return dispatchResult;
 
     // Special case: If it's a double click event, we also send the dblclick event. This is not part
     // of the DOM specs, but is used for compatibility with the ondblclick="" attribute. This is treated
     // as a separate event in other DOM-compliant browsers like Firefox, and so we do the same.
     MouseEvent* doubleClickEvent = MouseEvent::create();
     doubleClickEvent->initMouseEventInternal(EventTypeNames::dblclick, mouseEvent.bubbles(), mouseEvent.cancelable(), mouseEvent.view(),
         mouseEvent.detail(), mouseEvent.screenX(), mouseEvent.screenY(), mouseEvent.clientX(), mouseEvent.clientY(),
         mouseEvent.modifiers(), mouseEvent.button(), relatedTarget, mouseEvent.sourceCapabilities(), mouseEvent.buttons());
 
     // Inherit the trusted status from the original event.
     doubleClickEvent->setTrusted(mouseEvent.isTrusted());
     if (mouseEvent.defaultHandled())
         doubleClickEvent->setDefaultHandled();
     DispatchEventResult doubleClickDispatchResult = EventDispatcher::dispatchEvent(dispatcher.node(), MouseEventDispatchMediator::create(doubleClickEvent));
     if (doubleClickDispatchResult != DispatchEventResult::NotCanceled)
         return doubleClickDispatchResult;
     return dispatchResult;
 }
 
 } // namespace blink