Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: content/browser/renderer_host/web_input_event_aura.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new instances Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/web_input_event_aura.h" 5 #include "content/browser/renderer_host/web_input_event_aura.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "content/browser/renderer_host/input/web_input_event_util.h" 8 #include "content/browser/renderer_host/input/web_input_event_util.h"
9 #include "ui/aura/client/screen_position_client.h" 9 #include "ui/aura/client/screen_position_client.h"
10 #include "ui/aura/window.h" 10 #include "ui/aura/window.h"
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 webkit_event.text[0] = event.GetText(); 117 webkit_event.text[0] = event.GetText();
118 118
119 return webkit_event; 119 return webkit_event;
120 } 120 }
121 121
122 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent( 122 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
123 const ui::ScrollEvent& event) { 123 const ui::ScrollEvent& event) {
124 blink::WebMouseWheelEvent webkit_event; 124 blink::WebMouseWheelEvent webkit_event;
125 125
126 webkit_event.type = blink::WebInputEvent::MouseWheel; 126 webkit_event.type = blink::WebInputEvent::MouseWheel;
127 webkit_event.button = blink::WebMouseEvent::ButtonNone; 127 webkit_event.button = blink::WebMouseEvent::Button::NoButton;
128 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags()); 128 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags());
129 webkit_event.timeStampSeconds = 129 webkit_event.timeStampSeconds =
130 ui::EventTimeStampToSeconds(event.time_stamp()); 130 ui::EventTimeStampToSeconds(event.time_stamp());
131 webkit_event.hasPreciseScrollingDeltas = true; 131 webkit_event.hasPreciseScrollingDeltas = true;
132 132
133 float offset_ordinal_x = 0.f; 133 float offset_ordinal_x = 0.f;
134 float offset_ordinal_y = 0.f; 134 float offset_ordinal_y = 0.f;
135 if ((event.flags() & ui::EF_SHIFT_DOWN) != 0 && event.x_offset() == 0) { 135 if ((event.flags() & ui::EF_SHIFT_DOWN) != 0 && event.x_offset() == 0) {
136 webkit_event.deltaX = event.y_offset(); 136 webkit_event.deltaX = event.y_offset();
137 webkit_event.deltaY = 0; 137 webkit_event.deltaY = 0;
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 return gesture_event; 371 return gesture_event;
372 } 372 }
373 373
374 blink::WebMouseEvent MakeWebMouseEventFromAuraEvent( 374 blink::WebMouseEvent MakeWebMouseEventFromAuraEvent(
375 const ui::MouseEvent& event) { 375 const ui::MouseEvent& event) {
376 blink::WebMouseEvent webkit_event; 376 blink::WebMouseEvent webkit_event;
377 377
378 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags()); 378 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags());
379 webkit_event.timeStampSeconds = 379 webkit_event.timeStampSeconds =
380 ui::EventTimeStampToSeconds(event.time_stamp()); 380 ui::EventTimeStampToSeconds(event.time_stamp());
381 webkit_event.button = blink::WebMouseEvent::ButtonNone; 381 webkit_event.button = blink::WebMouseEvent::Button::NoButton;
382 int button_flags = event.flags(); 382 int button_flags = event.flags();
383 if (event.type() == ui::ET_MOUSE_PRESSED || 383 if (event.type() == ui::ET_MOUSE_PRESSED ||
384 event.type() == ui::ET_MOUSE_RELEASED) { 384 event.type() == ui::ET_MOUSE_RELEASED) {
385 // We want to use changed_button_flags() for mouse pressed & released. 385 // We want to use changed_button_flags() for mouse pressed & released.
386 // These flags can be used only if they are set which is not always the case 386 // These flags can be used only if they are set which is not always the case
387 // (see e.g. GetChangedMouseButtonFlagsFromNative() in events_win.cc). 387 // (see e.g. GetChangedMouseButtonFlagsFromNative() in events_win.cc).
388 if (event.changed_button_flags()) 388 if (event.changed_button_flags())
389 button_flags = event.changed_button_flags(); 389 button_flags = event.changed_button_flags();
390 } 390 }
391 if (button_flags & ui::EF_LEFT_MOUSE_BUTTON) 391 if (button_flags & ui::EF_LEFT_MOUSE_BUTTON)
392 webkit_event.button = blink::WebMouseEvent::ButtonLeft; 392 webkit_event.button = blink::WebMouseEvent::Button::Left;
393 if (button_flags & ui::EF_MIDDLE_MOUSE_BUTTON) 393 if (button_flags & ui::EF_MIDDLE_MOUSE_BUTTON)
394 webkit_event.button = blink::WebMouseEvent::ButtonMiddle; 394 webkit_event.button = blink::WebMouseEvent::Button::Middle;
395 if (button_flags & ui::EF_RIGHT_MOUSE_BUTTON) 395 if (button_flags & ui::EF_RIGHT_MOUSE_BUTTON)
396 webkit_event.button = blink::WebMouseEvent::ButtonRight; 396 webkit_event.button = blink::WebMouseEvent::Button::Right;
397 397
398 switch (event.type()) { 398 switch (event.type()) {
399 case ui::ET_MOUSE_PRESSED: 399 case ui::ET_MOUSE_PRESSED:
400 webkit_event.type = blink::WebInputEvent::MouseDown; 400 webkit_event.type = blink::WebInputEvent::MouseDown;
401 webkit_event.clickCount = event.GetClickCount(); 401 webkit_event.clickCount = event.GetClickCount();
402 break; 402 break;
403 case ui::ET_MOUSE_RELEASED: 403 case ui::ET_MOUSE_RELEASED:
404 webkit_event.type = blink::WebInputEvent::MouseUp; 404 webkit_event.type = blink::WebInputEvent::MouseUp;
405 webkit_event.clickCount = event.GetClickCount(); 405 webkit_event.clickCount = event.GetClickCount();
406 break; 406 break;
(...skipping 15 matching lines...) Expand all
422 EventPointerTypeToWebPointerType(event.pointer_details().pointer_type); 422 EventPointerTypeToWebPointerType(event.pointer_details().pointer_type);
423 423
424 return webkit_event; 424 return webkit_event;
425 } 425 }
426 426
427 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent( 427 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
428 const ui::MouseWheelEvent& event) { 428 const ui::MouseWheelEvent& event) {
429 blink::WebMouseWheelEvent webkit_event; 429 blink::WebMouseWheelEvent webkit_event;
430 430
431 webkit_event.type = blink::WebInputEvent::MouseWheel; 431 webkit_event.type = blink::WebInputEvent::MouseWheel;
432 webkit_event.button = blink::WebMouseEvent::ButtonNone; 432 webkit_event.button = blink::WebMouseEvent::Button::NoButton;
433 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags()); 433 webkit_event.modifiers = ui::EventFlagsToWebEventModifiers(event.flags());
434 webkit_event.timeStampSeconds = 434 webkit_event.timeStampSeconds =
435 ui::EventTimeStampToSeconds(event.time_stamp()); 435 ui::EventTimeStampToSeconds(event.time_stamp());
436 436
437 if ((event.flags() & ui::EF_SHIFT_DOWN) != 0 && event.x_offset() == 0) { 437 if ((event.flags() & ui::EF_SHIFT_DOWN) != 0 && event.x_offset() == 0) {
438 webkit_event.deltaX = event.y_offset(); 438 webkit_event.deltaX = event.y_offset();
439 webkit_event.deltaY = 0; 439 webkit_event.deltaY = 0;
440 } else { 440 } else {
441 webkit_event.deltaX = event.x_offset(); 441 webkit_event.deltaX = event.x_offset();
442 webkit_event.deltaY = event.y_offset(); 442 webkit_event.deltaY = event.y_offset();
443 } 443 }
444 444
445 webkit_event.wheelTicksX = webkit_event.deltaX / kPixelsPerTick; 445 webkit_event.wheelTicksX = webkit_event.deltaX / kPixelsPerTick;
446 webkit_event.wheelTicksY = webkit_event.deltaY / kPixelsPerTick; 446 webkit_event.wheelTicksY = webkit_event.deltaY / kPixelsPerTick;
447 447
448 webkit_event.tiltX = roundf(event.pointer_details().tilt_x); 448 webkit_event.tiltX = roundf(event.pointer_details().tilt_x);
449 webkit_event.tiltY = roundf(event.pointer_details().tilt_y); 449 webkit_event.tiltY = roundf(event.pointer_details().tilt_y);
450 webkit_event.force = event.pointer_details().force; 450 webkit_event.force = event.pointer_details().force;
451 webkit_event.pointerType = 451 webkit_event.pointerType =
452 EventPointerTypeToWebPointerType(event.pointer_details().pointer_type); 452 EventPointerTypeToWebPointerType(event.pointer_details().pointer_type);
453 453
454 return webkit_event; 454 return webkit_event;
455 } 455 }
456 456
457 } // namespace content 457 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698