[turbofan] Slightly improve typing rule for NumberAdd.

[turbofan] Slightly improve typing rule for NumberAdd.

Properly figure out NaN and -0 cases even for non-integer inputs. This
helps to reduce the number of checks we have to perform in case we try
to go back to int32 after a floating point operation.

R=jarin@chromium.org

Committed: https://crrev.com/13eae124e8634efb3a2a7f0b32b4f81557d70f16
Cr-Commit-Position: refs/heads/master@{#38413}

[Benedikt Meurer, 2016-08-08 05:54:51]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 05:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-08 06:01:03]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 06:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 06:27:24]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-08-08 06:43:59]

lgtm once the comment is addressed.

https://codereview.chromium.org/2227533002/diff/20001/src/compiler/operation-...
File src/compiler/operation-typer.cc (right):

https://codereview.chromium.org/2227533002/diff/20001/src/compiler/operation-...
src/compiler/operation-typer.cc:513: }
This sets maybe_minuszero if one side can be minus zero. You only want to set it
when both sides can be minus zero. E.g., you could say

  if (rhs->Maybe(Type::MinusZero())) {
    rhs = Type::Union(rhs, cache_.kSingletonZero, zone());
  } else {
    maybe_minuszero = false;
  }

[Benedikt Meurer, 2016-08-08 06:59:33]

https://codereview.chromium.org/2227533002/diff/20001/src/compiler/operation-...
File src/compiler/operation-typer.cc (right):

https://codereview.chromium.org/2227533002/diff/20001/src/compiler/operation-...
src/compiler/operation-typer.cc:513: }
Ah good point, thanks.

[Benedikt Meurer, 2016-08-08 06:59:39]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-08-08 06:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2227533002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-08-08 06:59:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 07:20:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 07:21:43]

Description was changed from

==========
[turbofan] Slightly improve typing rule for NumberAdd.

Properly figure out NaN and -0 cases even for non-integer inputs. This
helps to reduce the number of checks we have to perform in case we try
to go back to int32 after a floating point operation.

R=jarin@chromium.org
==========

to

==========
[turbofan] Slightly improve typing rule for NumberAdd.

Properly figure out NaN and -0 cases even for non-integer inputs. This
helps to reduce the number of checks we have to perform in case we try
to go back to int32 after a floating point operation.

R=jarin@chromium.org

Committed: https://crrev.com/13eae124e8634efb3a2a7f0b32b4f81557d70f16
Cr-Commit-Position: refs/heads/master@{#38413}
==========

[commit-bot: I haz the power, 2016-08-08 07:21:43]

Patchset 3 (id:??) landed as
https://crrev.com/13eae124e8634efb3a2a7f0b32b4f81557d70f16
Cr-Commit-Position: refs/heads/master@{#38413}