Pass input_jars_paths of libs to final proguard step

Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
Committed: https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5
Cr-Commit-Position: refs/heads/master@{#411358}

[agrieve, 2016-08-08 06:32:02]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-08-08 06:32:32]

The CQ bit was unchecked by agrieve@chromium.org

[agrieve, 2016-08-08 06:33:22]

https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:343: print(target_name,
_rebased_input_jars_paths)
oops. I'll have to zap this tomorrow.

[agrieve, 2016-08-08 06:33:34]

Description was changed from

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
==========

to

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
==========

[agrieve, 2016-08-08 06:33:34]

agrieve@chromium.org changed reviewers:
+ dgn@chromium.org

[agrieve, 2016-08-10 14:54:17]

On 2016/08/08 06:33:22, agrieve wrote:
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> File build/config/android/internal_rules.gni (right):
> 
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> build/config/android/internal_rules.gni:343: print(target_name,
> _rebased_input_jars_paths)
> oops. I'll have to zap this tomorrow.

Well... for some definition of "tomorrow" anyways :P. It's now zapped.

[agrieve, 2016-08-10 14:54:25]

On 2016/08/10 14:54:17, agrieve wrote:
> On 2016/08/08 06:33:22, agrieve wrote:
> >
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> > File build/config/android/internal_rules.gni (right):
> > 
> >
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> > build/config/android/internal_rules.gni:343: print(target_name,
> > _rebased_input_jars_paths)
> > oops. I'll have to zap this tomorrow.
> 
> Well... for some definition of "tomorrow" anyways :P. It's now zapped.

(lgty?)

[dgn, 2016-08-11 14:49:41]

On 2016/08/10 14:54:25, agrieve wrote:
> On 2016/08/10 14:54:17, agrieve wrote:
> > On 2016/08/08 06:33:22, agrieve wrote:
> > >
> >
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> > > File build/config/android/internal_rules.gni (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2227523002/diff/1/build/config/android/intern...
> > > build/config/android/internal_rules.gni:343: print(target_name,
> > > _rebased_input_jars_paths)
> > > oops. I'll have to zap this tomorrow.
> > 
> > Well... for some definition of "tomorrow" anyways :P. It's now zapped.
> 
> (lgty?)

lgtm, thanks! My patch still has some other http-related build issues, will look
into that later.

[agrieve, 2016-08-11 15:29:14]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:29:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:45:06]

Description was changed from

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
==========

to

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
==========

[commit-bot: I haz the power, 2016-08-11 16:45:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 16:46:24]

Description was changed from

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324
==========

to

==========
Pass input_jars_paths of libs to final proguard step

This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.

BUG=624324

Committed: https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5
Cr-Commit-Position: refs/heads/master@{#411358}
==========

[commit-bot: I haz the power, 2016-08-11 16:46:25]

Patchset 2 (id:??) landed as
https://crrev.com/71d53fa016887abec5807c7dfcd9e93ec0ab12a5
Cr-Commit-Position: refs/heads/master@{#411358}