Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/chromium/quic_http_stream_test.cc

Issue 2227503003: Add net log to UploadDataStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/log/net_log_event_type_list.h ('K') | « net/log/net_log_event_type_list.h ('k') | net/quic/core/quic_end_to_end_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_http_stream_test.cc
diff --git a/net/quic/chromium/quic_http_stream_test.cc b/net/quic/chromium/quic_http_stream_test.cc
index 38223eff18c5679b8373abd8ff21ac95121e3fbd..cd5e7896442ce2cdb592ec8e329678709bc23f1e 100644
--- a/net/quic/chromium/quic_http_stream_test.cc
+++ b/net/quic/chromium/quic_http_stream_test.cc
@@ -123,7 +123,7 @@ class ReadErrorUploadDataStream : public UploadDataStream {
void CompleteRead() { UploadDataStream::OnReadCompleted(ERR_FAILED); }
// UploadDataStream implementation:
- int InitInternal() override { return OK; }
+ int InitInternal(const BoundNetLog& net_log) override { return OK; }
int ReadInternal(IOBuffer* buf, int buf_len) override {
if (async_ == FailureMode::ASYNC) {
@@ -960,7 +960,9 @@ TEST_P(QuicHttpStreamTest, SendPostRequest) {
request_.method = "POST";
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
- ASSERT_THAT(request_.upload_data_stream->Init(CompletionCallback()), IsOk());
+ ASSERT_THAT(
+ request_.upload_data_stream->Init(CompletionCallback(), BoundNetLog()),
+ IsOk());
EXPECT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1026,7 +1028,7 @@ TEST_P(QuicHttpStreamTest, SendChunkedPostRequest) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
ASSERT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1096,7 +1098,7 @@ TEST_P(QuicHttpStreamTest, SendChunkedPostRequestWithFinalEmptyDataPacket) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
ASSERT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1160,7 +1162,7 @@ TEST_P(QuicHttpStreamTest, SendChunkedPostRequestWithOneEmptyDataPacket) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
ASSERT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1350,7 +1352,7 @@ TEST_P(QuicHttpStreamTest, SessionClosedDuringDoLoop) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
size_t chunk_size = strlen(kUploadData);
upload_data_stream.AppendData(kUploadData, chunk_size, false);
@@ -1378,7 +1380,7 @@ TEST_P(QuicHttpStreamTest, SessionClosedBeforeSendHeadersComplete) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
ASSERT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1403,7 +1405,7 @@ TEST_P(QuicHttpStreamTest, SessionClosedBeforeSendBodyComplete) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
ASSERT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1858,7 +1860,7 @@ TEST_P(QuicHttpStreamTest, DataReadErrorSynchronous) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
EXPECT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
@@ -1890,7 +1892,7 @@ TEST_P(QuicHttpStreamTest, DataReadErrorAsynchronous) {
request_.url = GURL("http://www.example.org/");
request_.upload_data_stream = &upload_data_stream;
ASSERT_EQ(OK, request_.upload_data_stream->Init(
- TestCompletionCallback().callback()));
+ TestCompletionCallback().callback(), BoundNetLog()));
EXPECT_EQ(OK,
stream_->InitializeStream(&request_, DEFAULT_PRIORITY,
« net/log/net_log_event_type_list.h ('K') | « net/log/net_log_event_type_list.h ('k') | net/quic/core/quic_end_to_end_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698