Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: src/compiler/operation-typer.cc

Issue 2227493002: [turbofan] Add initial support for growing stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/operation-typer.cc
diff --git a/src/compiler/operation-typer.cc b/src/compiler/operation-typer.cc
index 53c2770864864de5294d62403dfc8110677143da..d50862c61e406fb738a5dfd3c5ed46cf12c8c0c0 100644
--- a/src/compiler/operation-typer.cc
+++ b/src/compiler/operation-typer.cc
@@ -485,7 +485,10 @@ Type* OperationTyper::NumberToUint32(Type* type) {
Type* OperationTyper::NumberSilenceNaN(Type* type) {
DCHECK(type->Is(Type::Number()));
- // TODO(turbofan): We should have a dedicated type for the signaling NaN.
+ // TODO(jarin): This is a terrible hack; we definitely need a dedicated type
+ // for the hole (tagged and/or double). Otherwise if the input is the hole
+ // NaN constant, we'd just eliminate this node in JSTypedLowering.
+ if (type->Maybe(Type::NaN())) return Type::Number();
return type;
}
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698