src/compiler/operation-typer.cc - Issue 2227493002: [turbofan] Add initial support for growing stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/operation-typer.cc

Issue 2227493002: [turbofan] Add initial support for growing stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/operation-typer.cc

diff --git a/src/compiler/operation-typer.cc b/src/compiler/operation-typer.cc

index e81c81b567fe806a4bafff58c9f5f6793a9cfd7c..0a94919682d564d058a9b55bd87a8f00e0ba8e28 100644

--- a/src/compiler/operation-typer.cc

+++ b/src/compiler/operation-typer.cc

@@ -485,6 +485,7 @@ Type* OperationTyper::NumberToUint32(Type* type) {

Type* OperationTyper::NumberSilenceNaN(Type* type) {

DCHECK(type->Is(Type::Number()));

// TODO(turbofan): We should have a dedicated type for the signaling NaN.

Jarin 2016/08/08 08:03:47 Please add a comment that signposts a horrible hac

Benedikt Meurer 2016/08/08 08:12:55 Done.

+ if (type->Maybe(Type::NaN())) return Type::Number();

return type;

}