third_party/WebKit/LayoutTests/svg/animations/animateMotion_changingPath.html - Issue 2227463002: SVG: Use path attribute for animateMotion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/animateMotion_changingPath.html

Issue 2227463002: SVG: Use path attribute for animateMotion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #track {

	4 d: path('M20,100 H180');

	5 stroke: blue;

	6 }

	7 </style>

	8 <svg width="200" height="200" xmlns="http://www.w3.org/2000/svg"
	fs 2016/08/08 15:45:38 Nit: Don't need to declare NS's (the HTML parser o Nit: Don't need to declare NS's (the HTML parser open them automatically.) Eric Willigers 2016/08/10 01:13:15 Done. Show quoted text On 2016/08/08 15:45:38, fs (OoO until Aug 15) wrote: > Nit: Don't need to declare NS's (the HTML parser open them automatically.) Done.
	9 xmlns:xlink="http://www.w3.org/1999/xlink">

	10

	11 <path id="track" d="M20,20 H180"/>

	12

	13 <circle r="10" cx="0" cy="0" fill="green">

	14 <animateMotion dur="100ms" fill="freeze">

	15 <mpath xlink:href="#track"/>

	16 </animateMotion>

	17 </circle>

	18 </svg>

	19 <script>

	20 'use strict';

	21 if (window.testRunner)

	22 testRunner.waitUntilDone();

	23

	24 requestAnimationFrame(function() {
	fs 2016/08/08 15:45:38 If we can do the thing below, then I think we coul If we can do the thing below, then I think we could use the run-after-layout-and-paint.js helper here, then it'd just be: runAfterLayoutAndPaint(function() { document.getElementById('track').setAttribute('d', ...); }, true); (whether that is bound to happen after onload might be debatable, but equally so I think to using rAF.) Eric Willigers 2016/08/10 01:13:15 Done. Show quoted text On 2016/08/08 15:45:38, fs (OoO until Aug 15) wrote: > If we can do the thing below, then I think we could use the > run-after-layout-and-paint.js helper here, then it'd just be: > > runAfterLayoutAndPaint(function() { > document.getElementById('track').setAttribute('d', ...); > }, true); > > (whether that is bound to happen after onload might be debatable, but equally so > I think to using rAF.) Done.
	25 var track = document.getElementById('track');

	26 track.setAttribute('d', 'M100,20 V180');

	27 if (window.testRunner)

	28 setTimeout(function(){testRunner.notifyDone();}, 100);
	fs 2016/08/08 15:45:38 Could we avoid the 100ms delay by pausing the time Could we avoid the 100ms delay by pausing the timeline and using the point at t=0? Eric Willigers 2016/08/10 01:13:15 The animation has fill="freeze", so now I simply u Show quoted text On 2016/08/08 15:45:38, fs (OoO until Aug 15) wrote: > Could we avoid the 100ms delay by pausing the timeline and using the point at > t=0? The animation has fill="freeze", so now I simply update current time to when the animation completes.
	29 });

	30 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/animations/animateMotion_changingPath-expected.html » ('j') | no next file with comments »