Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2227453002: Revert of [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. (Closed)

Created:
4 years, 4 months ago by penny
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. (patchset #6 id:200001 of https://codereview.chromium.org/1854323002/ ) Reason for revert: Reverting the "on switch" temporarily. Want to look at the scope/details of broken IMEs more before re-landing. What percentage of Chrome IMEs are actually still using legacy hooking techniques to inject DLLs into our processes? Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=634192 Original issue's description: > [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. > > This CL is part of a chain of CLs: > 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) > 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) > 3) "New NT registry API" (https://codereview.chromium.org/1841573002) > 4) "Early browser security support" (https://codereview.chromium.org/1656453002) > -> THIS > > This CL only turns on the new mitigation (in all child processes, and early for the browser process). > > BUG=557798 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 > Cr-Commit-Position: refs/heads/master@{#409264} TBR=wfh@chromium.org,robertshield@chromium.org,nick@chromium.org,bradnelson@chromium.org,bradnelson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557798 Committed: https://crrev.com/406b433e8b3468b8c252a552119c0d65c7be874f Cr-Commit-Position: refs/heads/master@{#410293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M chrome/browser/win/chrome_elf_init.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/sandbox_helper_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/sandbox_win.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
penny
Created Revert of [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE.
4 years, 4 months ago (2016-08-08 02:05:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227453002/1
4 years, 4 months ago (2016-08-08 02:05:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 03:02:44 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 03:05:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/406b433e8b3468b8c252a552119c0d65c7be874f
Cr-Commit-Position: refs/heads/master@{#410293}

Powered by Google App Engine
This is Rietveld 408576698