third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html - Issue 2227423002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html

Issue 2227423002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed as per comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
	fs 2016/08/10 17:37:08 Could you make this just "<!DOCTYPE html>" while w Could you make this just "<!DOCTYPE html>" while we're at it? (Don't see anything here that require quirks mode.) sivag 2016/08/16 09:21:16 Done. Show quoted text On 2016/08/10 17:37:08, fs wrote: > Could you make this just "<!DOCTYPE html>" while we're at it? (Don't see > anything here that require quirks mode.) Done.
2 <html>	2 <title>This tests onerror event is fired if we change image src to a url blocked by content-security-policy.</title>

3 <head>

4 <meta http-equiv="Content-Security-Policy" content="img-src 'self'">	3 <meta http-equiv="Content-Security-Policy" content="img-src 'self'">

5 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <img src="./color-jpeg-with-color-profile-expected.png"></img>
	fs 2016/08/10 17:13:17 It was arguably a bit fishy to use <random-image-i It was arguably a bit fishy to use <random-image-in-the-same-directory-as-self>, but if it worked before... I don't think you should need to add the png file though? (That seems to cause the bots to fail too.) Preferably this should just use a more specific image than the expectation of a different test. sivag 2016/08/16 09:21:16 Done. I created a 11 png test image to test this Show quoted text On 2016/08/10 17:13:17, fs wrote: > It was arguably a bit fishy to use <random-image-in-the-same-directory-as-self>, > but if it worked before... I don't think you should need to add the png file > though? (That seems to cause the bots to fail too.) Preferably this should just > use a more specific image than the expectation of a different test. Done. I created a 11 png test image to test this.
6 <script>	7 <script>

7 description(	8 async_test(function(t) {

8 "This tests onerror event is fired if we change image src to a url blocked b y content-security-policy."	9 var img = document.querySelector("img");

9 )	10 img.onerror = t.step_func_done();

10	11 img.src = "http://www.myfakesiteabc.com/image.png";

11 jsTestIsAsync = true;	12 });

12

13 function load()

14 {

15 var image = document.getElementById('test');

16 image.onerror = function() {

17 testPassed("error event fired.");

18 finishJSTest();

19 };

20 image.src = 'http://www.myfakesiteabc.com/image.png';
fs 2016/08/10 17:13:17 This is not great - previously we were relying on This is not great - previously we were relying on the "CONSOLE ..." output to see if CSP blocked the load - now we can't really tell. It would seem better to put this test under http/ and make sure the destination actually exists. sivag 2016/08/16 09:21:16 Done. Show quoted text On 2016/08/10 17:13:17, fs wrote: > This is not great - previously we were relying on the "CONSOLE ..." output to > see if CSP blocked the load - now we can't really tell. It would seem better to > put this test under http/ and make sure the destination actually exists. Done.
21

22 setTimeout(function() {

23 testFailed("error event is not fired.")

24 finishJSTest();

25 }, 200);

26 }

27 </script>	13 </script>

28

29 </head>

30 <body onload='load()'>

31

32 <img src="./color-jpeg-with-color-profile-expected.png" id="test"></img>

33

34 </body>

35 </html>

OLD	NEW