third_party/WebKit/LayoutTests/http/tests/images/image-error-event-not-firing.html - Issue 2227423002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/images/image-error-event-not-firing.html

Issue 2227423002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed tests as per the comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html ('K') | « third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/resources/image-error-event-not-firing-test-image.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>This tests onerror event is fired if we change image src to a url blocked by content-security-policy.</title>

	3 <meta http-equiv="Content-Security-Policy" content="img-src 'self'">

	4 <script src="../../../resources/testharness.js"></script>

	5 <script src="../../../resources/testharnessreport.js"></script>

	6 <img src="../resources/image-error-event-not-firing-test-image.png"></img>
	fs 2016/08/16 10:42:42 We could arguably make this test more robust as we We could arguably make this test more robust as well by verifying that the initial reference loads ok. That's another potential TODO. fs 2016/08/16 10:44:55 Could probably also use one of the the square* fil Could probably also use one of the the square* files that already exists (to avoid adding very specific files like this one.) sivag 2016/08/16 11:54:21 Done. Show quoted text On 2016/08/16 10:42:42, fs wrote: > We could arguably make this test more robust as well by verifying that the > initial reference loads ok. That's another potential TODO. Done. sivag 2016/08/16 11:54:21 Done. Show quoted text On 2016/08/16 10:44:55, fs wrote: > Could probably also use one of the the square* files that already exists (to > avoid adding very specific files like this one.) Done.
	7 <script>

	8 async_test(function(t) {

	9 var img = document.querySelector("img");

	10 img.onerror = t.step_func_done();

	11 img.src = "http://127.0.0.1:8000/resources/image-error-event-not-firing-test -image.png";

	12 });

	13 </script>

OLD	NEW