third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html - Issue 2227423002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html

Issue 2227423002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Give correct location of resources folder. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html ('K') | « third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/images/image-error-event-not-firing.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <title>crbug.com/468915: Resetting or removing the src attribute should reset th e image immediately, rather than waiting for an asynchronous load to do it.</tit le>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

3 <script>	5 <script>

4 if (window.testRunner) {	6 async_test(function(t) {

5 testRunner.waitUntilDone();	7 var img = new Image();

6 testRunner.dumpAsText();	8 img.onload = t.step_func_done(function() {

7 }

8 img = new Image();

9 var testImage = 'resources/green.jpg';

10 img.onload = function(){

11 img.removeAttribute('src');	9 img.removeAttribute('src');

12 if (img.naturalWidth > 0) {	10 assert_equals(img.naturalWidth, 0);
	fs 2016/08/16 09:39:37 Maybe add an additional assert of img.naturalWidth Maybe add an additional assert of img.naturalWidth (as non-zero) before the removeAttribute call. sivag 2016/08/16 10:06:40 Done. Show quoted text On 2016/08/16 09:39:37, fs wrote: > Maybe add an additional assert of img.naturalWidth (as non-zero) before the > removeAttribute call. Done.
13 debug("Natural width is : " + img.naturalWidth + " and should be 0." );	11 });

14 if (window.testRunner)	12 img.src = 'resources/green.jpg';

15 testRunner.notifyDone();	13 });

16 return;

17 }

18 document.getElementById('result').textContent = "PASS";

19 if (window.testRunner)

20 testRunner.notifyDone();

21 };

22 setTimeout(function() {

23 img.src = testImage;

24 }, 0);

25 </script>	14 </script>

26 <div id="console">

27 crbug.com/468915: Resetting or removing the src attribute should reset the i mage immediately, rather than waiting for an asynchronous load to do it.<br>

28 </div>

29 <div id="result">FAIL</div>

30

OLD	NEW