third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html - Issue 2227423002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html

Issue 2227423002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Give correct location of resources folder. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <title>This test ensures that when an image changes, but doesn't change size (li ke in an Animated GIF), we don't force a Layout.</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <div style="float: left;">

	6 <img style="max-width: 100%" src="../replaced/resources/1x1-blue.png">

	7 </div>

3 <script>	8 <script>

4 description("This test ensures that when an image changes, but doesn't change si ze (like in an Animated GIF), we don't force a Layout.")	9 test(function() {

5

6 if (window.testRunner)

7 testRunner.waitUntilDone();

8

9 function runTest() {

10 document.documentElement.offsetTop;	10 document.documentElement.offsetTop;

11 var imageElement = document.getElementById("image");	11 var img = document.querySelector("img");

12 imageElement.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCA MAAAAoyzS7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZT wAAAAGUExURf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII="	12 img.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAMAAAAoyzS 7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAAGUEx URf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII=";

13 if (window.internals)	13 assert_equals(internals.needsLayoutCount(), 0);
	fs 2016/08/16 09:39:37 I think we could make this test a bit more "future I think we could make this test a bit more "future-safe" by also waiting for img.onload and then asserting the same there. So: test -> async_test (passing t to the test function) and img.onload = t.step_func_done(function() { assert_equals(internals.needsLayoutCount(), 0); }); Probably should wait for window.onload too as well before setting img.src then. Hopefully that isn't too strict. (Feel free to leave this to a follow-up.) sivag 2016/08/16 10:06:40 Done. Will change this in a follow-up patch. Show quoted text On 2016/08/16 09:39:37, fs wrote: > I think we could make this test a bit more "future-safe" by also waiting for > img.onload and then asserting the same there. So: > > test -> async_test (passing t to the test function) > > and > > img.onload = t.step_func_done(function() { > assert_equals(internals.needsLayoutCount(), 0); > }); > > Probably should wait for window.onload too as well before setting img.src then. > Hopefully that isn't too strict. > > (Feel free to leave this to a follow-up.) Done. Will change this in a follow-up patch.
14 shouldBe("window.internals.needsLayoutCount()", "0");	14 });

15 if (window.testRunner)

16 testRunner.notifyDone();

17 };

18 </script>	15 </script>

19 <body onload="runTest();">

20 <div style="float: left;">

21 <img id="image" style="max-width: 100%" src="../replaced/resources/1x1-blue. png">

22 </div>

OLD	NEW