third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html - Issue 2227423002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html

Issue 2227423002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <title>"This test ensures that when an image changes, but doesn't change size (l ike in an Animated GIF), we don't force a Layout."</title>
	Srirama 2016/08/10 06:59:47 nit: remove the quotes. nit: remove the quotes. sivag 2016/08/10 09:17:48 Done. Show quoted text On 2016/08/10 06:59:47, Srirama wrote: > nit: remove the quotes. Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

3 <script>	5 <script>

4 description("This test ensures that when an image changes, but doesn't change si ze (like in an Animated GIF), we don't force a Layout.")	6 async_test(function(t) {
	Srirama 2016/08/10 06:59:47 Please check if you can use synchronous test inste Please check if you can use synchronous test instead of async_test by keeping the original image tag before this script element and forcing a layout using "document.documentElement.offsetTop;". Just confirm if the test is failing or not by forcefully changing the image size. sivag 2016/08/10 09:17:48 Done. Show quoted text On 2016/08/10 06:59:47, Srirama wrote: > Please check if you can use synchronous test instead of async_test by keeping > the original image tag before this script element and forcing a layout using > "document.documentElement.offsetTop;". Just confirm if the test is failing or > not by forcefully changing the image size. Done.
5	7 var img = new Image();

6 if (window.testRunner)	8 img.style = "max-width: 100%";

7 testRunner.waitUntilDone();	9 img.src = "../replaced/resources/1x1-blue.png";

8	10 img.onload = t.step_func_done(function() {

9 function runTest() {	11 img.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAMAAAA oyzS7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAA GUExURf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII=";

10 document.documentElement.offsetTop;	12 assert_equals(window.internals.needsLayoutCount(), 0);
	Srirama 2016/08/10 06:59:47 nit: you can omit window prefix. nit: you can omit window prefix. sivag 2016/08/10 09:17:48 Done. Show quoted text On 2016/08/10 06:59:47, Srirama wrote: > nit: you can omit window prefix. Done.
11 var imageElement = document.getElementById("image");	13 });

12 imageElement.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCA MAAAAoyzS7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZT wAAAAGUExURf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII="	14 });

13 if (window.internals)

14 shouldBe("window.internals.needsLayoutCount()", "0");

15 if (window.testRunner)

16 testRunner.notifyDone();

17 };

18 </script>	15 </script>

19 <body onload="runTest();">

20 <div style="float: left;">

21 <img id="image" style="max-width: 100%" src="../replaced/resources/1x1-blue. png">

22 </div>

OLD	NEW