Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2227403002: Remove blink::ReadableStream (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove blink::ReadableStream This CL removes two stable runtime enabled flags - ResponseConstructedWithReadableStream - ResponseBodyWithV8ExtraStream and related code including blink::ReadableStream. BUG=613435 Committed: https://crrev.com/d800220da9f744779f1989e2092c88770adcd20a Cr-Commit-Position: refs/heads/master@{#411014}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2285 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 3 chunks +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableByteStream.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableByteStream.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableByteStream.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableByteStreamReader.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableByteStreamReader.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStream.h View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStream.cpp View 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamImpl.h View 1 chunk +0 lines, -235 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamReader.h View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamReader.cpp View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamReader.idl View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp View 1 chunk +0 lines, -586 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp View 1 chunk +0 lines, -654 lines 0 comments Download
D third_party/WebKit/Source/core/streams/UnderlyingSource.h View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h View 5 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 9 chunks +50 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 2 chunks +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
yhirano
4 years, 4 months ago (2016-08-10 07:27:53 UTC) #10
tyoshino (SeeGerritForStatus)
lgtm
4 years, 4 months ago (2016-08-10 07:58:18 UTC) #13
yhirano
+tkent@ for core.gypi and RuntimeEnabledFeatures.in.
4 years, 4 months ago (2016-08-10 08:02:20 UTC) #15
tkent
lgtm
4 years, 4 months ago (2016-08-10 08:40:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227403002/20001
4 years, 4 months ago (2016-08-10 09:03:30 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 09:39:11 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 09:41:08 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d800220da9f744779f1989e2092c88770adcd20a
Cr-Commit-Position: refs/heads/master@{#411014}

Powered by Google App Engine
This is Rietveld 408576698