src/hydrogen-instructions.h - Issue 22274017: Handle external reference values properly in HConstant::ImmortalImmovable().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 22274017: Handle external reference values properly in HConstant::ImmortalImmovable(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index 1dbedbd52af497a34e84ef2974c437973ffbfcd1..3fae45bcb7663b8b8e50f86b9852eea2a65b38fd 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -3212,6 +3212,9 @@ class HConstant: public HTemplateInstruction<0> {

}

return false;

}

+ if (has_external_reference_value_) {

+ return false;

+ }

ASSERT(!handle_.is_null());

Heap* heap = isolate()->heap();

« no previous file with comments | « no previous file | no next file » | no next file with comments »