Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: chrome/browser/resources/md_downloads/vulcanized.html

Issue 2227373002: chrome://downloads: Fix a regression by RTL-aware input[type=search]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_downloads/vulcanized.html
diff --git a/chrome/browser/resources/md_downloads/vulcanized.html b/chrome/browser/resources/md_downloads/vulcanized.html
index 97576539de245f72a02ff798d42a861c6bd17b16..ec7d87a352b402349958c48187260cf13d19a898 100644
--- a/chrome/browser/resources/md_downloads/vulcanized.html
+++ b/chrome/browser/resources/md_downloads/vulcanized.html
@@ -2456,8 +2456,11 @@ paper-input-container {
}
#searchTerm input[type='search']::-webkit-search-cancel-button {
- display: block;
- width: 20px;
+ display: none;
+}
+
+#searchTerm input[type='search'] {
+ padding-right: 20px;
Dan Beam 2016/08/10 18:00:39 can we just use -webkit-padding-start?
tkent 2016/08/12 08:30:47 No. Did you mean -webkit-padding-end? Anyway, log
}
paper-icon-button {
@@ -2490,6 +2493,11 @@ paper-icon-button {
right: auto;
}
+:host-context([dir='rtl']) #searchTerm input[type='search'] {
+ padding-left: 20px;
+ padding-right: 0;
+}
+
</style>
<paper-icon-button icon="cr:search" id="searchButton" disabled$="[[showingSearch]]" title="[[label]]" on-tap="toggleShowingSearch_"></paper-icon-button>
<paper-input-container id="searchTerm" on-search="onSearchTermSearch" on-keydown="onSearchTermKeydown" hidden$="[[!showingSearch]]" no-label-float="">
@@ -2789,4 +2797,4 @@ paper-button {
<command id="find-command" shortcut="Ctrl|f"></command>
</if>
<link rel="import" href="chrome://resources/html/polymer.html">
- <script src="crisper.js"></script></body></html>
+ <script src="crisper.js"></script></body></html>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698