chrome://downloads: Fix a regression by RTL-aware input[type=search].

chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG=635790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2e5ce8b8b6563ad06c752d8cc767c927ad764693
Cr-Commit-Position: refs/heads/master@{#412389}

[tkent, 2016-08-10 04:07:17]

Description was changed from

==========
chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG=635790
==========

to

==========
chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG=635790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tkent, 2016-08-10 04:07:29]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 04:08:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 05:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 05:23:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tkent, 2016-08-10 05:51:39]

tkent@chromium.org changed reviewers:
+ dbeam@chromium.org

[tkent, 2016-08-10 05:51:39]

dbeam@, would you review this please?

[Dan Beam, 2016-08-10 18:00:40]

can you update toolbar.html and then run
chrome/browser/resources/md_downloads/vulcanize.py instead?

https://codereview.chromium.org/2227373002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/vulcanized.html (right):

https://codereview.chromium.org/2227373002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/vulcanized.html:2463: padding-right: 20px;
can we just use -webkit-padding-start?

[Dan Beam, 2016-08-10 18:02:43]

On 2016/08/10 18:00:40, Dan Beam wrote:
> can you update toolbar.html and then run
> chrome/browser/resources/md_downloads/vulcanize.py instead?

probably also helpful:
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/resour...

[tkent, 2016-08-12 08:30:47]

On 2016/08/10 at 18:02:43, dbeam wrote:
> On 2016/08/10 18:00:40, Dan Beam wrote:
> > can you update toolbar.html and then run
> > chrome/browser/resources/md_downloads/vulcanize.py instead?
> 
> probably also helpful:
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/resour...

Thank you for the information!
I searched the directory for README.md, but I didn't find vulcanize_readme.md :D

Unfortunately installing crisper and vulcanize failed on my Linux box.  So let
me update vulcanized.html and cr_search_field.css manually.

https://codereview.chromium.org/2227373002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/vulcanized.html (right):

https://codereview.chromium.org/2227373002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/vulcanized.html:2463: padding-right: 20px;
On 2016/08/10 at 18:00:39, Dan Beam wrote:
> can we just use -webkit-padding-start?

No.  Did you mean -webkit-padding-end?
Anyway, logical paddings don't work. ::-webkit-search-cancel-button already
secured space at 'end' position.  The problem is that the direction of the
search input and the direction of other elements are mismatched.

[tkent, 2016-08-12 09:23:25]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 09:23:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 10:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 10:21:44]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-12 21:21:23]

yes, meant -webkit-padding-end

if that doesn't work, lgtm

[tkent, 2016-08-16 23:08:11]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:04:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 00:08:09]

Description was changed from

==========
chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG=635790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG=635790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2e5ce8b8b6563ad06c752d8cc767c927ad764693
Cr-Commit-Position: refs/heads/master@{#412389}
==========

[commit-bot: I haz the power, 2016-08-17 00:08:10]

Patchset 2 (id:??) landed as
https://crrev.com/2e5ce8b8b6563ad06c752d8cc767c927ad764693
Cr-Commit-Position: refs/heads/master@{#412389}