Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2227353002: Subzero: Added ASan quarantine for recently freed objects (Closed)

Created:
4 years, 4 months ago by tlively
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Added ASan quarantine for recently freed objects BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e8392d82f0f54c36af50f1c2280a4c954cd2000b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added check for double free errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -9 lines) Patch
M runtime/szrt_asan.c View 1 7 chunks +74 lines, -9 lines 0 comments Download
A tests_lit/asan_tests/doublefree.ll View 1 1 chunk +24 lines, -0 lines 0 comments Download
A tests_lit/asan_tests/quarantine.ll View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tlively
Note: I'm not sure pthreads is available for any of the build targets.
4 years, 4 months ago (2016-08-10 03:39:44 UTC) #2
Karl
https://codereview.chromium.org/2227353002/diff/1/runtime/szrt_asan.c File runtime/szrt_asan.c (right): https://codereview.chromium.org/2227353002/diff/1/runtime/szrt_asan.c#newcode255 runtime/szrt_asan.c:255: size_t total_size = rz_right_size + (rz_right - rz_left); Can't ...
4 years, 4 months ago (2016-08-10 16:15:46 UTC) #3
tlively
https://codereview.chromium.org/2227353002/diff/1/runtime/szrt_asan.c File runtime/szrt_asan.c (right): https://codereview.chromium.org/2227353002/diff/1/runtime/szrt_asan.c#newcode255 runtime/szrt_asan.c:255: size_t total_size = rz_right_size + (rz_right - rz_left); On ...
4 years, 4 months ago (2016-08-10 17:17:57 UTC) #4
Karl
lgtm
4 years, 4 months ago (2016-08-10 17:22:09 UTC) #5
tlively
4 years, 4 months ago (2016-08-10 17:36:29 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e8392d82f0f54c36af50f1c2280a4c954cd2000b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698