Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1823)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2227343002: Add Browser Task Scheduler Flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust DCHECK message Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 419488dbc7704b48c18aa5544b35d54ae488e6f0..c53ee500ce16e6c00e28fde801dcb7df068b144c 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -37,6 +37,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/sys_info.h"
#include "base/task_scheduler/scheduler_worker_pool_params.h"
+#include "base/task_scheduler/switches.h"
#include "base/task_scheduler/task_scheduler.h"
#include "base/task_scheduler/task_traits.h"
#include "base/threading/platform_thread.h"
@@ -394,8 +395,15 @@ size_t WorkerPoolIndexForTraits(const base::TaskTraits& traits) {
void MaybeInitializeTaskScheduler() {
static constexpr char kFieldTrialName[] = "BrowserScheduler";
std::map<std::string, std::string> variation_params;
- if (!variations::GetVariationParams(kFieldTrialName, &variation_params))
+ if (!variations::GetVariationParams(kFieldTrialName, &variation_params)) {
+ DCHECK(!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserTaskScheduler))
+ << "The Browser Task Scheduler remains disabled with "
+ << switches::kEnableBrowserTaskScheduler
+ << " because there is no available variation param for this build or "
+ " the task scheduler is disabled in chrome://flags.";
return;
+ }
using ThreadPriority = base::ThreadPriority;
using IORestriction = base::SchedulerWorkerPoolParams::IORestriction;
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698