base/task_scheduler/switches.cc - Issue 2227343002: Add Browser Task Scheduler Flags

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/task_scheduler/switches.cc

Issue 2227343002: Add Browser Task Scheduler Flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/task_scheduler/switches.h"

	6

	7 namespace switches {

	8

	9 const char kDisableBrowserTaskScheduler[] = "disable-browser-task-scheduler";

	10 const char kEnableBrowserTaskScheduler[] = "enable-browser-task-scheduler";
	gab 2016/08/10 16:48:57 Can we have a DCHECK in chrome if --enable-browser Can we have a DCHECK in chrome if --enable-browser-task-scheduler but we don't have valid variations for it? Then a developer using this without variations (i.e. dev build for which Finch hasn't been synced yet) will not be left debugging for hours before realizing he's missing variations. (that'd also make a nice place to add a code comment on how the mapping is done server-side :-)) robliao 2016/08/10 20:10:52 Added a DCHECK in the variations check. Show quoted text On 2016/08/10 16:48:57, gab wrote: > Can we have a DCHECK in chrome if --enable-browser-task-scheduler but we don't > have valid variations for it? Then a developer using this without variations > (i.e. dev build for which Finch hasn't been synced yet) will not be left > debugging for hours before realizing he's missing variations. > > (that'd also make a nice place to add a code comment on how the mapping is done > server-side :-)) Added a DCHECK in the variations check.
	11

	12 } // namespace switches

OLD	NEW

« no previous file with comments | « base/task_scheduler/switches.h ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »