DescriptionRevert of Change InputMethodController#setSelectionOffsets() to use NotUserTriggered parameter (patchset #3 id:40001 of https://codereview.chromium.org/2206923002/ )
Reason for revert:
ImeTest#testFinishComposingText failed.
We need to fix the test before relanding it.
Original issue's description:
> Change InputMethodController#setSelectionOffsets() to use
> NotUserTriggered parameter
>
> InputMethodController#setSelectionOffsets() should have no side
> effect other than changing the selection. But
> FrameSelection::CloseTyping will close typing, causing the failure of
> canceling the composing text when inserting line break. We should
> use NotUserTriggered parameter because it has no side effect.
>
> BUG=633840
>
> Committed: https://crrev.com/786070a33bcfebaff78b304401a4137e8dadccd8
> Cr-Commit-Position: refs/heads/master@{#410577}
TBR=yosin@chromium.org,aelias@chromium.org,changwan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633840
Committed: https://crrev.com/dd122a409bd085efd4a566ea950755bdd60d2866
Cr-Commit-Position: refs/heads/master@{#410905}
Patch Set 1 #
Messages
Total messages: 12 (5 generated)
|