Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2227333002: Revert of Change InputMethodController#setSelectionOffsets() to use NotUserTriggered parameter (Closed)

Created:
4 years, 4 months ago by yabinh
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change InputMethodController#setSelectionOffsets() to use NotUserTriggered parameter (patchset #3 id:40001 of https://codereview.chromium.org/2206923002/ ) Reason for revert: ImeTest#testFinishComposingText failed. We need to fix the test before relanding it. Original issue's description: > Change InputMethodController#setSelectionOffsets() to use > NotUserTriggered parameter > > InputMethodController#setSelectionOffsets() should have no side > effect other than changing the selection. But > FrameSelection::CloseTyping will close typing, causing the failure of > canceling the composing text when inserting line break. We should > use NotUserTriggered parameter because it has no side effect. > > BUG=633840 > > Committed: https://crrev.com/786070a33bcfebaff78b304401a4137e8dadccd8 > Cr-Commit-Position: refs/heads/master@{#410577} TBR=yosin@chromium.org,aelias@chromium.org,changwan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633840 Committed: https://crrev.com/dd122a409bd085efd4a566ea950755bdd60d2866 Cr-Commit-Position: refs/heads/master@{#410905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yabinh
Created Revert of Change InputMethodController#setSelectionOffsets() to use NotUserTriggered parameter
4 years, 4 months ago (2016-08-10 00:47:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227333002/1
4 years, 4 months ago (2016-08-10 00:48:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 00:48:59 UTC) #5
Changwan Ryu
On 2016/08/10 00:48:59, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 4 months ago (2016-08-10 00:49:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227333002/1
4 years, 4 months ago (2016-08-10 00:50:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 00:52:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 00:56:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd122a409bd085efd4a566ea950755bdd60d2866
Cr-Commit-Position: refs/heads/master@{#410905}

Powered by Google App Engine
This is Rietveld 408576698