Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2227323002: Revert of Store mipmap levels in deferred texture image (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Store mipmap levels in deferred texture image (patchset #11 id:200001 of https://codereview.chromium.org/2115023002/ ) Reason for revert: speculative revert: android dm crashes Original issue's description: > Store mipmap levels in deferred texture image > > This is a follow-up to https://codereview.chromium.org/2034933003/ which > was reverted due to a memory leak. > > When creating the deferred texture image, detect if using medium / high > quality. If so, generate and store mipmaps in the deferred texture > image. > > When creating a texture from that be sure to read it back out. > > BUG=578304 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2115023002 > > Committed: https://skia.googlesource.com/skia/+/d6113140f7ae8996f679ac6698a60fb8c1386da3 TBR=brianosman@google.com,bsalomon@google.com,ericrk@chromium.org,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578304 Committed: https://skia.googlesource.com/skia/+/e9d55c57a6537108ddebdc7afe2b92b4d83426be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -317 lines) Patch
D gm/deferredtextureimage.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
A gm/deferredtextureimagedata.cpp View 1 chunk +81 lines, -0 lines 0 comments Download
M include/core/SkImage.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/image/SkImage.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 8 chunks +18 lines, -108 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of Store mipmap levels in deferred texture image
4 years, 4 months ago (2016-08-10 00:46:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227323002/1
4 years, 4 months ago (2016-08-10 00:46:15 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 00:46:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e9d55c57a6537108ddebdc7afe2b92b4d83426be

Powered by Google App Engine
This is Rietveld 408576698