Issue 222723002: Fix matrix adjustment passed to filter processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222723002: Fix matrix adjustment passed to filter processing. (Closed)

Created:
6 years, 8 months ago by Stephen White

Modified:
6 years, 8 months ago

Reviewers:
bsalomon, bsalomon_chromium

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix matrix adjustment passed to filter processing. When adjusting the CTM for filter use, we were subtracting off the destination coordinates of the drawDevice() or drawSprite(). This is not quite correct: we should subtract off the coordinates relative to the device origin instead. This occurs when one filtered saveLayer() is drawn inside another saveLayer(), both with non-zero origin. This fixes layout test svg/batik/text/smallFonts.svg in Blink, and is exercised by the provided unit test. BUG=skia: R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=14029

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -2 lines)			Patch
	M	src/core/SkCanvas.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tests/ImageFilterTest.cpp	View		2 chunks	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

6 years, 8 months ago (2014-04-02 19:20:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14029 (presubmit successful).

Expand Messages | Collapse Messages