chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc - Issue 2227193002: Make UserScript non-copyable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

Issue 2227193002: Make UserScript non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync @tott Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_handler.cc ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

index bcb0d529f4442858c8769d5156b0ed3109e72941..8083e552d7c20ebbfc58d40e84455e966fbc4991 100644

--- a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

@@ -80,12 +80,12 @@ TEST_F(ContentScriptsManifestTest, ContentScriptIds) {

const UserScriptList& user_scripts1 =

ContentScriptsInfo::GetContentScripts(extension1.get());

ASSERT_EQ(1u, user_scripts1.size());

- int id = user_scripts1[0].id();

+ int id = user_scripts1[0]->id();

const UserScriptList& user_scripts2 =

ContentScriptsInfo::GetContentScripts(extension2.get());

ASSERT_EQ(1u, user_scripts2.size());

// The id of the content script should be one higher than the previous.

- EXPECT_EQ(id + 1, user_scripts2[0].id());

+ EXPECT_EQ(id + 1, user_scripts2[0]->id());

}

TEST_F(ContentScriptsManifestTest, FailLoadingNonUTF8Scripts) {