Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: extensions/browser/web_ui_user_script_loader.h

Issue 2227193002: Make UserScript non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from Devlin Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/web_ui_user_script_loader.h
diff --git a/extensions/browser/web_ui_user_script_loader.h b/extensions/browser/web_ui_user_script_loader.h
index 0bba40c2def7094565b65925d6f52e106c5c15a5..edff2341ed253b8a48dba0cf5cc00c21742e6a28 100644
--- a/extensions/browser/web_ui_user_script_loader.h
+++ b/extensions/browser/web_ui_user_script_loader.h
@@ -32,7 +32,7 @@ class WebUIUserScriptLoader : public extensions::UserScriptLoader {
using UserScriptRenderInfoMap = std::map<int, UserScriptRenderInfo>;
// UserScriptLoader:
- void AddScripts(const extensions::UserScriptList& scripts,
+ void AddScripts(std::unique_ptr<extensions::UserScriptList> scripts,
int render_process_id,
int render_frame_id) override;
void LoadScripts(std::unique_ptr<extensions::UserScriptList> user_scripts,
@@ -49,10 +49,11 @@ class WebUIUserScriptLoader : public extensions::UserScriptLoader {
void OnWebUIURLFetchComplete();
// Creates WebUiURLFetchers for the given |script_files|.
- void CreateWebUIURLFetchers(extensions::UserScript::FileList* script_files,
- content::BrowserContext* browser_context,
- int render_process_id,
- int render_frame_id);
+ void CreateWebUIURLFetchers(
+ const extensions::UserScript::FileList& script_files,
+ content::BrowserContext* browser_context,
+ int render_process_id,
+ int render_frame_id);
// Caches the render info of script from WebUI when AddScripts is called.
// When starting to load the script, we look up this map to retrieve the

Powered by Google App Engine
This is Rietveld 408576698