Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/declarative_user_script_master.h

Issue 2227193002: Make UserScript non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove browser/renderer specific file impl as it is not helping much Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/declarative_user_script_master.h
diff --git a/extensions/browser/declarative_user_script_master.h b/extensions/browser/declarative_user_script_master.h
index a0570103b488367bf0434fa5826310c68ea45eab..9887166ea7c966a2aa56267531359889e9f71912 100644
--- a/extensions/browser/declarative_user_script_master.h
+++ b/extensions/browser/declarative_user_script_master.h
@@ -35,19 +35,19 @@ class DeclarativeUserScriptMaster {
// Adds script to shared memory region. This may not happen right away if a
// script load is in progress.
- void AddScript(const UserScript& script);
+ void AddScript(std::unique_ptr<UserScript> script);
// Adds a set of scripts to shared meomory region. The fetch of the content
// of the script on WebUI requires to start URL request to the associated
// render specified by |render_process_id, render_frame_id|.
// This may not happen right away if a script load is in progress.
- void AddScripts(const std::vector<UserScript>& scripts,
+ void AddScripts(std::vector<std::unique_ptr<UserScript>>& scripts,
Devlin 2016/08/17 16:39:31 UserScriptList? Also I think style disallows pass
lazyboy 2016/08/17 18:55:52 UserScriptList is in user_script.h, which we're no
int render_process_id,
int render_frame_id);
// Removes script from shared memory region. This may not happen right away if
// a script load is in progress.
- void RemoveScript(const UserScript& script);
+ void RemoveScript(const UserScriptIDPair& script);
// Removes a set of scripts from shared memory region. This may not happen
// right away if a script load is in progress.

Powered by Google App Engine
This is Rietveld 408576698