Make UserScript non-copyable.

extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/guest_view/web_view/web_view_internal_api.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 68 matching lines @@
   if (web_contents && web_contents->GetWebUI()) {
     const GURL& url = web_contents->GetSiteInstance()->GetSiteURL();
     return HostID(HostID::WEBUI, url.spec());
   }
   NOTREACHED();
   return HostID();
 }
 
 // Creates content script files when parsing InjectionItems of "js" or "css"
 // proterties, and stores them in the |result|.
-void AddScriptFiles(const GURL& owner_base_url,
-                    const extensions::Extension* extension,
-                    const InjectionItems& items,
-                    UserScript::FileList* result) {
+void ParseScriptFiles(const GURL& owner_base_url,
+                      const extensions::Extension* extension,
+                      const InjectionItems& items,
+                      UserScript::FileList* list) {
+  DCHECK(list->size() == 0u);

[Devlin, 2016/08/17 16:39:30]

list->empty()

[lazyboy, 2016/08/17 18:55:52]

Done.

+  list->reserve((items.files.get() ? items.files->size() : 0) +
+                (items.code.get() ? 1 : 0));

[Devlin, 2016/08/17 16:39:30]

ditto re unique_ptr bool op

[lazyboy, 2016/08/17 18:55:52]

Done.

   // files:
   if (items.files) {
     for (const std::string& relative : *items.files) {
       GURL url = owner_base_url.Resolve(relative);
       if (extension) {
         ExtensionResource resource = extension->GetResource(relative);
-        result->push_back(UserScript::File(resource.extension_root(),
-                                           resource.relative_path(), url));
+
+        list->push_back(base::WrapUnique(new extensions::UserScript::File(
+            resource.extension_root(), resource.relative_path(), url)));
       } else {
-        result->push_back(extensions::UserScript::File(base::FilePath(),
-                                                       base::FilePath(), url));
+        list->push_back(base::WrapUnique(new extensions::UserScript::File(
+            base::FilePath(), base::FilePath(), url)));
       }
     }
   }
   // code:
   if (items.code) {
-    extensions::UserScript::File file((base::FilePath()), (base::FilePath()),
-                                      GURL());
-    file.set_content(*items.code);
-    result->push_back(file);
+    std::unique_ptr<extensions::UserScript::File> file(
+        new extensions::UserScript::File(base::FilePath(), base::FilePath(),
+                                         GURL()));
+    file->set_content(*items.code);
+    list->push_back(std::move(file));
   }
 }
 
 // Parses the values stored in ContentScriptDetails, and constructs a
-// UserScript.
-bool ParseContentScript(const ContentScriptDetails& script_value,
-                        const extensions::Extension* extension,
-                        const GURL& owner_base_url,
-                        UserScript* script,
-                        std::string* error) {
+// user script.
+std::unique_ptr<extensions::UserScript> ParseContentScript(
+    const ContentScriptDetails& script_value,
+    const extensions::Extension* extension,
+    const GURL& owner_base_url,
+    std::string* error) {
   // matches (required):
   if (script_value.matches.empty())
-    return false;
+    return std::unique_ptr<extensions::UserScript>();
+
+  std::unique_ptr<extensions::UserScript> script =
+      base::WrapUnique(new extensions::UserScript());
 
   // The default for WebUI is not having special access, but we can change that
   // if needed.
   bool allowed_everywhere = false;
   if (extension &&
       extensions::PermissionsData::CanExecuteScriptEverywhere(extension))
     allowed_everywhere = true;
 
   for (const std::string& match : script_value.matches) {
     URLPattern pattern(UserScript::ValidUserScriptSchemes(allowed_everywhere));
     if (pattern.Parse(match) != URLPattern::PARSE_SUCCESS) {
       *error = errors::kInvalidMatches;
-      return false;
+      return std::unique_ptr<extensions::UserScript>();
     }
     script->add_url_pattern(pattern);
   }
 
   // exclude_matches:
   if (script_value.exclude_matches) {
     const std::vector<std::string>& exclude_matches =
         *(script_value.exclude_matches.get());
     for (const std::string& exclude_match : exclude_matches) {
       URLPattern pattern(
           UserScript::ValidUserScriptSchemes(allowed_everywhere));
 
       if (pattern.Parse(exclude_match) != URLPattern::PARSE_SUCCESS) {
         *error = errors::kInvalidExcludeMatches;
-        return false;
+        return std::unique_ptr<extensions::UserScript>();
       }
       script->add_exclude_url_pattern(pattern);
     }
   }
   // run_at:
   if (script_value.run_at) {
     UserScript::RunLocation run_at = UserScript::UNDEFINED;
     switch (script_value.run_at) {
       case extensions::api::extension_types::RUN_AT_NONE:
       case extensions::api::extension_types::RUN_AT_DOCUMENT_IDLE:
         run_at = UserScript::DOCUMENT_IDLE;
         break;
       case extensions::api::extension_types::RUN_AT_DOCUMENT_START:
         run_at = UserScript::DOCUMENT_START;
         break;
       case extensions::api::extension_types::RUN_AT_DOCUMENT_END:
         run_at = UserScript::DOCUMENT_END;
         break;
     }
     // The default for run_at is RUN_AT_DOCUMENT_IDLE.
     script->set_run_location(run_at);
   }
 
   // match_about_blank:
   if (script_value.match_about_blank)
     script->set_match_about_blank(*script_value.match_about_blank);
 
   // css:
   if (script_value.css) {
-    AddScriptFiles(owner_base_url, extension, *script_value.css,
-                   &script->css_scripts());
+    ParseScriptFiles(owner_base_url, extension, *script_value.css,
+                     &script->css_scripts());
   }
 
   // js:
   if (script_value.js) {
-    AddScriptFiles(owner_base_url, extension, *script_value.js,
-                   &script->js_scripts());
+    ParseScriptFiles(owner_base_url, extension, *script_value.js,
+                     &script->js_scripts());
   }
 
   // all_frames:
   if (script_value.all_frames)
     script->set_match_all_frames(*script_value.all_frames);
 
   // include_globs:
   if (script_value.include_globs) {
     for (const std::string& glob : *script_value.include_globs)
       script->add_glob(glob);
   }
 
   // exclude_globs:
   if (script_value.exclude_globs) {
     for (const std::string& glob : *script_value.exclude_globs)
       script->add_exclude_glob(glob);
   }
 
-  return true;
+  return script;
 }
 
 bool ParseContentScripts(
     const std::vector<ContentScriptDetails>& content_script_list,
     const extensions::Extension* extension,
     const HostID& host_id,
     bool incognito_enabled,
     const GURL& owner_base_url,
     extensions::UserScriptList* result,
     std::string* error) {
   if (content_script_list.empty())
     return false;
 
   std::set<std::string> names;
   for (const ContentScriptDetails& script_value : content_script_list) {
     const std::string& name = script_value.name;
     if (!names.insert(name).second) {
       // The name was already in the list.
       *error = kDuplicatedContentScriptNamesError;
       return false;
     }
 
-    UserScript script;
-    if (!ParseContentScript(script_value, extension, owner_base_url, &script,
-                            error))
+    std::unique_ptr<extensions::UserScript> script =
+        ParseContentScript(script_value, extension, owner_base_url, error);
+    if (!script.get())
       return false;
-
-    script.set_id(UserScript::GenerateUserScriptID());
-    script.set_name(name);
-    script.set_incognito_enabled(incognito_enabled);
-    script.set_host_id(host_id);
-    script.set_consumer_instance_type(UserScript::WEBVIEW);
-    result->push_back(script);
+    script->set_id(UserScript::GenerateUserScriptID());
+    script->set_name(name);
+    script->set_incognito_enabled(incognito_enabled);
+    script->set_host_id(host_id);
+    script->set_consumer_instance_type(extensions::UserScript::WEBVIEW);
+    result->push_back(std::move(script));
   }
   return true;
 }
 
 }  // namespace
 
 namespace extensions {
 
 bool LegacyWebViewInternalExtensionFunction::RunAsync() {
   int instance_id = 0;
@@ skipping 711 matching lines @@
   // Will finish asynchronously.
   return true;
 }
 
 void WebViewInternalClearDataFunction::ClearDataDone() {
   Release();  // Balanced in RunAsync().
   SendResponse(true);
 }
 
 }  // namespace extensions